You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/01/24 23:36:28 UTC
[jclouds] Trying an upgrade to Guava 16.0 (#265)
Invokable.equals has changed from 15 to 16 so we need to implement the check differently ourselves.
**Work In Progress**. Please do not merge yet. Just want to see the PR builders and get feedback.
See [JCLOUDS-415](https://issues.apache.org/jira/browse/JCLOUDS-415)
You can merge this Pull Request by running:
git pull https://github.com/jclouds/jclouds JCLOUDS-415
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/265
-- Commit Summary --
* Trying an upgrade to Guava 16.0
-- File Changes --
M core/pom.xml (2)
M core/src/main/java/org/jclouds/rest/internal/DelegatesToInvocationFunction.java (18)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/265.patch
https://github.com/jclouds/jclouds/pull/265.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265
Re: [jclouds] Trying an upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #999](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/999/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33271842
Re: [jclouds] Trying an upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #532](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/532/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33278712
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #534](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/534/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33299300
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #780](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/780/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33418108
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1002 UNSTABLE
Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1002/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/). And no new checkstyle warnings added by this change, indeed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33299534
Re: [jclouds] Trying an upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #999 UNSTABLE
Spurious [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/999/testReport/junit/org.jclouds.compute.util/ConcurrentOpenSocketFinderTest/testChecksSocketsConcurrently/)
Some checkstyle warnings worth cleaning up, though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33276660
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
> @@ -120,18 +120,18 @@ public final Object invoke(Object proxy, Method invoked, @Nullable Object[] argv
> Invokable<?, Object> invokable = method(ownerType, invoked);
> Invocation invocation = Invocation.create(invokable, args);
> try {
> - return handle(invocation);
> + return handle(invocation, invoked);
See https://github.com/jclouds/jclouds/commit/c49489afc8d3e910067469bf62bc9f335db64825 for an alternative approach. This changes the method signature but is a smaller change overall.
Pity we can't get the method _back_ from the [`Invokable`](http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/reflect/Invokable.html). If we want to leave the method sig the same we *could* create some kind of "MethodExposingInvokable", though..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265/files#r9200541
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Gaul <no...@github.com>.
> @@ -120,18 +120,18 @@ public final Object invoke(Object proxy, Method invoked, @Nullable Object[] argv
> Invokable<?, Object> invokable = method(ownerType, invoked);
> Invocation invocation = Invocation.create(invokable, args);
> try {
> - return handle(invocation);
> + return handle(invocation, invoked);
Right, backport should not upgrade Guava, only work around for the handful of users who use a newer Guava with an older jclouds version.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265/files#r9201858
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #536](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/536/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33419734
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
> @@ -120,18 +120,18 @@ public final Object invoke(Object proxy, Method invoked, @Nullable Object[] argv
> Invokable<?, Object> invokable = method(ownerType, invoked);
> Invocation invocation = Invocation.create(invokable, args);
> try {
> - return handle(invocation);
> + return handle(invocation, invoked);
> +1
For this one or the idea of a "MethodExposingInvokable"? ;-) And, if I understand correctly, what we want to backport to 1.7.x is _just_ the change here, not the POM change.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265/files#r9201743
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
Committed [to](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=d77f96bed7ab3938388670f7051547cee66d9522) [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=ea5128209a111ac3b74a6c3297e8b9dc7b635ef8)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33478058
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Gaul <no...@github.com>.
> @@ -120,18 +120,18 @@ public final Object invoke(Object proxy, Method invoked, @Nullable Object[] argv
> Invokable<?, Object> invokable = method(ownerType, invoked);
> Invocation invocation = Invocation.create(invokable, args);
> try {
> - return handle(invocation);
> + return handle(invocation, invoked);
:+1:
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265/files#r9200896
Re: [jclouds] Trying an upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1000](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1000/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33278711
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1003](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1003/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33412670
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
No (new) complaints from Checkstyle, either. Going in tomorrow or so...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33425184
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by Andrew Phillips <no...@github.com>.
@andrewgaul: Cleaned up - hopefully no checkstyle problems added by this commit. Let's see what the PR builders say.
Otherwise, good to go?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33297419
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1004](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1004/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33419910
Re: [jclouds] JCLOUDS-415: Upgrade to Guava 16.0 (#265)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #781](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/781/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/265#issuecomment-33423224