[jira] [Work logged] (AMQNET-631) extension methods missing in 1.8.0 e.g. SessionExtensions.GetDestination

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQNET-631?focusedWorklogId=376082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376082 ]

ASF GitHub Bot logged work on AMQNET-631:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jan/20 06:48
            Start Date: 23/Jan/20 06:48
    Worklog Time Spent: 10m 
      Work Description: Havret commented on issue #11: AMQNET-631: Restore session extensions api
URL: https://github.com/apache/activemq-nms-api/pull/11#issuecomment-577530079
 
 
   I believe it was breaking for the folks that were using old version of .net framework or mono. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 376082)
    Remaining Estimate: 0h
            Time Spent: 10m

> extension methods missing in 1.8.0 e.g. SessionExtensions.GetDestination
> ------------------------------------------------------------------------
>
>                 Key: AMQNET-631
>                 URL: https://issues.apache.org/jira/browse/AMQNET-631
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: NMS
>    Affects Versions: 1.8.0
>         Environment: Windows / .NET Framework 4.x
>            Reporter: Bruce Dodson
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After updating NMS to 1.8.0 in my project, I am getting build errors indicating that the GetDestination method is not available on ISession. 
> This method is defined in the SessionExtensions class, but it is conditionally included only if the symbol MONO or NET_3_5 is defined.
> This symbol must have been defined previously, but is now omitted as part of the cleanup that was done for 1.8.
> Perhaps the extension methods could be defined for any supported version of .NET at this point, assuming .NET < 3.5 is no longer supported by the project at all?
> The extension method simply delegates to SessionUtil.GetDestination, which is exposed to public as well, so to work around the issue for my immediate need I just called that directly. However, the extension methods should still be provided as before, rather than have a breaking change.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)