You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/18 12:05:54 UTC

[GitHub] igalshilman commented on issue #7732: [FLINK-9803] Drop canEqual() from TypeSerializer

igalshilman commented on issue #7732: [FLINK-9803] Drop canEqual() from TypeSerializer
URL: https://github.com/apache/flink/pull/7732#issuecomment-464707879
 
 
   All and all, 👍 for removing dead code.
   
   There might be a slight potential issue with `InstantSerializer` since it does not define a `serialVersionUID` and removing the `canEqual` will change the auto generated value.
   
   Can you please add to `InstantSeiralizer`:
   `private static final long serialVersionUID = -4131715684999061277L;`
   
   Guess we'll have to wait for Travis,  but other than that LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services