You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/12/17 16:22:31 UTC

[GitHub] tajo pull request: TAJO-1249: Tajo Should Check File Format is all...

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/305

    TAJO-1249: Tajo Should Check File Format is allowed.

    Currently Tajo just show NullPointException when can't understand file format
    ```c
    default> create external table table1 ( id int, name text, score float, type text, mytime int, mytime2 date) using TEXT1 location 'file:/Users/charsyam/tajo/table';
    ERROR: java.lang.NullPointerException
    ```
    after patch
    ```c
    default> create table table1 (       id int,       name text,       score float,       type text, mytime int) USING csv1;
    ERROR: csv1 is not supported storage type.
    ```
    
    I added code in LogicalPlanner.java because I think it is more clear and easy to understand. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/TAJO-1249

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #305
    
----
commit d227691369e71460055cbdde083d476518fba27a
Author: clark.kang <cl...@kakao.com>
Date:   2014-12-17T15:19:31Z

    TAJO-1249

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1249: Tajo Should Check File Format is all...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/305#issuecomment-67436403
  
    Hi @charsyam 
    
    Thank you for your contribution.
    LogicalPlanVerifier provide logical plan validation. I think you'd better update LogicalPlanVerifier::visitCreateTable.
    
    Cheers
    Jaehwa


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1249: Tajo Should Check File Format is all...

Posted by charsyam <gi...@git.apache.org>.

Github user charsyam closed the pull request at:

    https://github.com/apache/tajo/pull/305


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1249: Tajo Should Check File Format is all...

Posted by blrunner <gi...@git.apache.org>.

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/305#issuecomment-67439800
  
    I give new opinion again. I think you'd better use PreLogicalPlanVerifier instead of LogicalPlanVerifier. PreLogicalPlanVerifier provide query validation before creating local plan.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---