You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2024/04/11 08:36:14 UTC
[PR] [INLONG-9976][Manager] Support multiple types of audit indicator queries [inlong]
fuweng11 opened a new pull request, #9979:
URL: https://github.com/apache/inlong/pull/9979
### Prepare a Pull Request
- Fixes #9976
### Motivation
Support multiple types of audit indicator queries.
### Modifications
Support multiple types of audit indicator queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9976][Manager] Support multiple types of audit indicator queries [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #9979:
URL: https://github.com/apache/inlong/pull/9979#discussion_r1560773153
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java:
##########
@@ -133,9 +134,7 @@ public class AuditServiceImpl implements AuditService {
private static final String TERMS = "terms";
// key: type of audit base item, value: entity of audit base item
- private final Map<String, AuditBaseEntity> auditSentItemMap = new ConcurrentHashMap<>();
-
- private final Map<String, AuditBaseEntity> auditReceivedItemMap = new ConcurrentHashMap<>();
+ private final Map<String, Map<Integer, AuditBaseEntity>> auditIndicatorMap = new ConcurrentHashMap<>();
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9976][Manager] Support multiple types of audit indicator queries [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #9979:
URL: https://github.com/apache/inlong/pull/9979#discussion_r1560671964
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java:
##########
@@ -133,9 +134,7 @@ public class AuditServiceImpl implements AuditService {
private static final String TERMS = "terms";
// key: type of audit base item, value: entity of audit base item
- private final Map<String, AuditBaseEntity> auditSentItemMap = new ConcurrentHashMap<>();
-
- private final Map<String, AuditBaseEntity> auditReceivedItemMap = new ConcurrentHashMap<>();
+ private final Map<String, Map<Integer, AuditBaseEntity>> auditIndicatorMap = new ConcurrentHashMap<>();
Review Comment:
doc should keep consistent with code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9976][Manager] Support multiple types of audit indicator queries [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9979:
URL: https://github.com/apache/inlong/pull/9979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org