You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/14 01:09:08 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28324: Add `version_renamed` and `previous_name` in config sections

jedcunningham commented on code in PR #28324:
URL: https://github.com/apache/airflow/pull/28324#discussion_r1047906563


##########
docs/apache-airflow/configurations-ref.rst:
##########
@@ -48,6 +48,10 @@ that you run airflow components on is synchronized (for example using ntpd) othe
     [{{ section["name"] }}]
     {{ "=" * (section["name"]|length + 2) }}
 
+    {% if 'renamed' in section %}
+    *{{"Renamed in version "+ section['renamed']['version']+", previous name was "+ section['renamed']['previous_name'] }}*

Review Comment:
   ```suggestion
       *Renamed in version {{ section['renamed']['version'] }}, previous name was {{ section['renamed']['previous_name'] }}*
   ```
   
   nit, assuming this works this seems cleaner?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org