You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by godfreyhe <gi...@git.apache.org> on 2017/09/19 02:44:20 UTC

[GitHub] flink pull request #4682: [FLINK-7620] [table] Supports user defined optimiz...

GitHub user godfreyhe opened a pull request:

    https://github.com/apache/flink/pull/4682

    [FLINK-7620] [table] Supports user defined optimization phase

    ## What is the purpose of the change
    
    *This pull request makes Flink supports user defined optimization phase. before this PR, the optimization phases are hardcode in BatchTableEnvironment and StreamTableEnvironment, It's hard to add a new optimization phase or adjust the phase-orders. This PR makes it more flexible for developer and user.*
    
    
    ## Brief change log
    
      - *Adds new interface FlinkOptimizeProgram which represents an optimization phase to transform a relational expression into another relational expression*
      - *Moves the optimization phases from BatchTableEnvironment/StreamTableEnvironment to FlinkBatchPrograms /FlinkStreamPrograms using new implementation*
      - *Removes the useless code(such as getLogicalOptRuleSet, replaceNormRules). Updates the corresponding implementations*
      - *Updates existed test cases, adds new test cases*
    
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *IT cases could validates new implementation about  the optimization phases*.
    
    This change added tests and can be verified as follows:
    - *Added test that validates the correct of FlinkChainedPrograms implementation*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/godfreyhe/flink FLINK-7620

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4682
    
----
commit c9001e684a892a15f3eb59d1b6c7dc5ecf9be189
Author: godfreyhe <go...@163.com>
Date:   2017-09-19T01:59:22Z

    [FLINK-7620] [table] Supports user defined optimization phase

----


---