You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zlei929 <gi...@git.apache.org> on 2018/05/24 07:51:28 UTC
[GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
GitHub user zlei929 opened a pull request:
https://github.com/apache/trafodion/pull/1578
[TRAFODION-3070] we cannot comment on native hive table.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zlei929/trafodion master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1578
----
commit c24c712f926b99a38a55e14f6ecdff282525b124
Author: zlei929 <z_...@...>
Date: 2018-05-23T03:45:23Z
[TRAFODION-3070] we cannot comment on native hive table.
----
---
[GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
Posted by zlei929 <gi...@git.apache.org>.
Github user zlei929 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1578#discussion_r190774048
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -229,6 +229,16 @@ void CmpSeabaseDDL::doSeabaseCommentOn(StmtDDLCommentOn *commentOnNode,
enum ComObjectType enMDObjType = COM_UNKNOWN_OBJECT;
ComObjectName objectName(commentOnNode->getObjectName());
+ //we can not comment on native hive table.
+ if (str_cmp(toUpper(currCatName.data()), "HIVE", 4) == 0)
--- End diff --
Thank you for your reminding~! i will create a new pull request after changed this.
---
[GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1578#discussion_r190645064
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -515,6 +515,7 @@
1718 ZZZZZ 99999 BEGINNER MINOR DBADMIN --- unused ---
1719 ZZZZZ 99999 BEGINNER MINOR DBADMIN Access Type '$0~string0' is not supported.
1720 ZZZZZ 99999 BEGINNER MINOR DBADMIN Isolation Level '$0~string0' is not supported.
+1721 ZZZZZ 99999 BEGINNER MINOR DBADMIN Cannot comment on '$0~string0' if this is a native hive table.
--- End diff --
"hive" should be capitalized. Also, please add this new message to the Trafodion Messages Guide. You can find the source for that in the trafodion/docs/messages_guide directory.
---
[GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1578#discussion_r190645661
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommentOn.cpp ---
@@ -229,6 +229,16 @@ void CmpSeabaseDDL::doSeabaseCommentOn(StmtDDLCommentOn *commentOnNode,
enum ComObjectType enMDObjType = COM_UNKNOWN_OBJECT;
ComObjectName objectName(commentOnNode->getObjectName());
+ //we can not comment on native hive table.
+ if (str_cmp(toUpper(currCatName.data()), "HIVE", 4) == 0)
--- End diff --
Please use the literal HIVE_SYSTEM_CATALOG (see common/ComSmallDefs.h) instead of hard-coding "HIVE".
---
[GitHub] trafodion pull request #1578: [TRAFODION-3070] we cannot comment on native h...
Posted by zlei929 <gi...@git.apache.org>.
Github user zlei929 commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1578#discussion_r190773995
--- Diff: core/sql/bin/SqlciErrors.txt ---
@@ -515,6 +515,7 @@
1718 ZZZZZ 99999 BEGINNER MINOR DBADMIN --- unused ---
1719 ZZZZZ 99999 BEGINNER MINOR DBADMIN Access Type '$0~string0' is not supported.
1720 ZZZZZ 99999 BEGINNER MINOR DBADMIN Isolation Level '$0~string0' is not supported.
+1721 ZZZZZ 99999 BEGINNER MINOR DBADMIN Cannot comment on '$0~string0' if this is a native hive table.
--- End diff --
Thanks, and i'm sorry that i did not see this document(https://cwiki.apache.org/confluence/display/TRAFODION/How+to+Add+A+New+SQL+Error+Diagnostic) until I pull this request, i will solve this problem in the next pull request.
---