You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2015/10/14 21:51:28 UTC
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/799
[STORM-1110] Fix Component Page for system components
- Remove redundant method `system-id?` - as is calls into static `Utils/isSystemId`
- All System components are of type bolts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm storm1110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #799
----
commit 8281115371e852eb540246fd127b29d1da5e6f6a
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-10-14T18:45:20Z
Remove redundent clojure method system-id
commit 88bfa5af12ec07c0fb4c2d4a66f1812fee004edf
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-10-14T18:46:32Z
The system components are of type bolts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-149365765
Since there're so many random test failures for now, we may be OK to treat test is passed when more than one of two Travis build are success.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-148178178
+1 pending no relevant build issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by kishorvpatil <gi...@git.apache.org>.
GitHub user kishorvpatil reopened a pull request:
https://github.com/apache/storm/pull/799
[STORM-1110] Fix Component Page for system components
- Remove redundant method `system-id?` - as is calls into static `Utils/isSystemId`
- All System components are of type bolts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm storm1110
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/799.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #799
----
commit 8281115371e852eb540246fd127b29d1da5e6f6a
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-10-14T18:45:20Z
Remove redundent clojure method system-id
commit 88bfa5af12ec07c0fb4c2d4a66f1812fee004edf
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-10-14T18:46:32Z
The system components are of type bolts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-148193041
Tests pass on my machine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-148177465
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-149356704
testing travis build..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-148182253
The failures look unrelated. We got failures in nimbus-auth-test, but nothing showed up in the logs, so I am not really sure how/why they failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-148178374
+1 pending build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1110] Fix Component Page for system com...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/799#issuecomment-149566508
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---