You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/03/09 11:22:02 UTC

[GitHub] [ignite-3] tledkov-gridgain commented on a change in pull request #708: IGNITE-16593 Schema should keep colocation information

tledkov-gridgain commented on a change in pull request #708:
URL: https://github.com/apache/ignite-3/pull/708#discussion_r822546525



##########
File path: modules/schema/src/main/java/org/apache/ignite/internal/schema/configuration/SchemaConfigurationConverter.java
##########
@@ -230,7 +230,7 @@ public static IndexDefinition convert(TableIndexView idxView) {
      * @return TableIn.
      */
     public static PrimaryKeyDefinition convert(PrimaryKeyView primaryKey) {
-        return new PrimaryKeyDefinitionImpl(Set.of(primaryKey.columns()), Set.of(primaryKey.affinityColumns()));
+        return new PrimaryKeyDefinitionImpl(Set.of(primaryKey.columns()), List.of(primaryKey.colocationColumns()));

Review comment:
       Fixed. Check moved to constructor of fhe `PrimaryKeyDefinitionImpl`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org