You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/26 16:14:23 UTC

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6708: adding strategies peering ring generation to t3c

rob05c commented on code in PR #6708:
URL: https://github.com/apache/trafficcontrol/pull/6708#discussion_r858911195


##########
lib/go-atscfg/parentdotconfig.go:
##########
@@ -839,7 +865,11 @@ func getParentDSParams(ds DeliveryService, profileParentConfigParams map[string]
 	if !ok {
 		return params, warnings
 	}
-
+	if val, ok := dsParams[StrategyConfigUsePeering]; ok {
+		if val == "true" {

Review Comment:
   Nitpick: this should probably ignore the value, and consider it always true if the Param exists, to be consistent with the behavior of other boolean params



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org