You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/05/01 05:46:12 UTC
Review Request 66884: ATLAS-2633: Tag Propagation ,
V2 notifications : When propagate value is switched from False to True ,
"CLASSIFICATION_UPDATE" notification is sent instead of "CLASSIFICATION_ADD"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66884/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2633
https://issues.apache.org/jira/browse/ATLAS-2633
Repository: atlas
Description
-------
Create a lineage like the following :
table1 -----> process1 -------> table2
Added tag1 to table1 with propagate set to False.
Edited tag1 at table1 and set propagate to True.
Expected operationType CLASSIFICATION_ADD for process1 and table2 but found CLASSIFICATION_UPDATE message for table2 and process1.
CLASSIFICATION_UPDATE for table1 is expected but CLASSIFICATION_ADD is expected for table2 and process1.
Diffs
-----
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 1fb032a8
Diff: https://reviews.apache.org/r/66884/diff/1/
Testing
-------
Thanks,
Sarath Subramanian
Re: Review Request 66884: ATLAS-2633: Tag Propagation ,
V2 notifications : When propagate value is switched from False to True ,
"CLASSIFICATION_UPDATE" notification is sent instead of "CLASSIFICATION_ADD"
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66884/#review202191
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 1, 2018, 5:46 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66884/
> -----------------------------------------------------------
>
> (Updated May 1, 2018, 5:46 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2633
> https://issues.apache.org/jira/browse/ATLAS-2633
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create a lineage like the following :
>
> table1 -----> process1 -------> table2
>
> Added tag1 to table1 with propagate set to False.
> Edited tag1 at table1 and set propagate to True.
>
> Expected operationType CLASSIFICATION_ADD for process1 and table2 but found CLASSIFICATION_UPDATE message for table2 and process1.
>
> CLASSIFICATION_UPDATE for table1 is expected but CLASSIFICATION_ADD is expected for table2 and process1.
>
>
> Diffs
> -----
>
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 1fb032a8
>
>
> Diff: https://reviews.apache.org/r/66884/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/321/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>