You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Tom Jordahl <to...@macromedia.com> on 2004/01/08 23:21:27 UTC

RE: WSDL2Java removed implementation.

Magnus,

I like the idea of this, but as I was trying to integrate your code it seems
that the behavior of WSDL2Java will change in not immediately obvious ways
and that would be bad.

Can we preserve the original behavior of NOT overwriting an existing Impl
file (and warning the user) *unless* we find the magic markers in the file,
then we can do the magic?

So it would work like this

- No Impl
  - write the file

- Impl exists:
  - magic markers, replace file and preserve code
  - no markers, do not replace file and warn as usual

I would also think a switch to control this behavior would be useful too.
Something that would turn off the magic marker processing and always/never
replace the Impl.  If you do add a switch, make sure to patch the reference
documentation for WSDL2Java in the docs directory.

Thanks!

--
Tom Jordahl
Macromedia Server Development

-----Original Message-----
From: Magnus Sandberg [mailto:magnus.sandberg@azzets.com] 
Sent: Wednesday, November 12, 2003 6:57 AM
To: axis-dev@ws.apache.org
Subject: WSDL2Java removed implementation.


Hi,

I'm working on a quite big webservice and I grew a bit tired of the fact
that WSDL2Java didn't keep my code changes in the Impl file.

So patched JavaBindingWriter and JavaImplWriter so that any old Impl
file is parsed and the any user modifications are keeps and added to the
new Impl file.

The modifications must be made between the two magic markers added to
the Impl file.

A patch is provided in this mail, please forgive me if this is not the
correct format or forum for this. Also the quality of the code is not
perfect, if this is somethings that you feel could be usefully to add to
axis I'm willing to improve the implementation.

Cheers,

/Magnus