You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/12 06:02:25 UTC
[GitHub] [incubator-mxnet] sandeep-krishnamurthy opened a new pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
sandeep-krishnamurthy opened a new pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520
## Description ##
This PR files Item 6 in this issue - https://github.com/apache/incubator-mxnet/issues/20475
1. Remove redundant ASF license header when there is Microsoft Apache 2.0 license and copyright header.
2. Remove stale copyright by authors.
3. Add relevant files with Apache 2.0 license + Microsoft copyright in LICENSE file
## Checklist ##
### Essentials ###
- [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [X] Changes are complete (i.e. I finished coding on this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-899542369
> That may be a mistake in LICENSE rather than mistaken license header in the file. The original code is at https://github.com/msracver/Deformable-ConvNets/blob/6aeda878a95bcb55eadffbe125804e730574de8d/DCNv2_op/modulated_deformable_convolution.cc and under MIT license. "Do not modify or remove any copyright notices or licenses within third-party works." https://www.apache.org/legal/src-headers.html#3party
Ah! thanks for source repo. Fixed issues as below:
1. There were 6 files (deformable_*, modulated_deformable_* ops) under MIT per source repo. They are not substantially modified. Removed ASF 2.0 header in them. Maintained original MIT. Updated list of these files in LICENSE file under MIT license section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy edited a comment on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy edited a comment on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-897947410
- Here is the PR that introduced these files - https://github.com/apache/incubator-mxnet/pull/6298/files
- No ICLA from contributors. Hence, copyright notices had to be left as is.
- However, since it is Apache 2.0 licensed, MXNet is compliant with these files.
As an additional step, I reached out to contributors, if they can file ICLA, if yes, we can have common ASF header and remove copyright, which is not necessary (since these files are Apache 2.0 license) but nice to have.
* [Yuwen Xiong](https://github.com/Orpine/)
* [Haozhi Qi](https://github.com/Oh233/)
* [Yi Li](https://github.com/liyi14/)
* [Guodong Zhang](https://github.com/gd-zhang/)
* [Xizhou Zhu](https://github.com/einsiedler0408/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-897947410
- Here is the PR that introduced these files - https://github.com/apache/incubator-mxnet/pull/6298/files
- No ICLA from contributors. Hence, copyright notices had to be left as is.
- However, since it is Apache 2.0 licensed, MXNet is compliant with these files.
As an additional step, I will reach to contributors, if they can file ICLA, if yes, we can have common ASF header, which is not necessary (since these files are Apache 2.0 license) but nice to have.
* [Yuwen Xiong](https://github.com/Orpine/)
* [Haozhi Qi](https://github.com/Oh233/)
* [Yi Li](https://github.com/liyi14/)
* [Guodong Zhang](https://github.com/gd-zhang/)
* [Xizhou Zhu](https://github.com/einsiedler0408/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898968852
You removed ` * Licensed under The MIT License` from 5 files in this PR. You can search the string in https://github.com/apache/incubator-mxnet/pull/20520/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#discussion_r687991554
##########
File path: LICENSE
##########
@@ -284,6 +284,22 @@
3rdparty/openmp
+ =======================================================================================
+ Apache-2.0 license + Microsoft Copyright
Review comment:
This would be the only section making claims about who holds copyright to the code. For consistency, I suggest we focus on the licenses in the LICENSE file. Thus, these files don't need to explicitly called out, as they are AL2 licensed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898055613
Jenkins CI successfully triggered : [unix-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-897956987
@leezu
>> Copyright notices shouldn't go to LICENSE AFAIK. At least it's not required and for consistency we may want to keep them out. WDYT?
Agreed. They are Apache 2.0 license. Copyright need not come here in License file.
>> Can you confirm that the reason for removing the ASF headers is that you think the files only contain minor modifications compared to the original Microsoft AL2 implementation? For major modifications, it's totally fine to add ASF header. https://www.apache.org/legal/src-headers.html#3party
That is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898211484
@mxnet-bot run ci [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898211509
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898818166
> Thank you @sandeep-krishnamurthy. I noticed that 5 of the files are licensed under MIT license by Microsoft, but they are not listed in the LICENSE file
I don't see any MIT license files in this PR. Are you referring to other files outside this PR?
All the files in this PR are Caffe license (verified they are in LICENSE) and rest of Apache 2.0 license with Microsoft copyright (since they are Apache 2.0 license, did not explicitly specified in LICENSE file).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898256858
@leezu CI is green. Requesting your review/merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-897371605
Hey @sandeep-krishnamurthy , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, unix-cpu, centos-cpu, clang, website, edge, windows-gpu, centos-gpu, miscellaneous, windows-cpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#discussion_r687994666
##########
File path: LICENSE
##########
@@ -284,6 +284,22 @@
3rdparty/openmp
+ =======================================================================================
+ Apache-2.0 license + Microsoft Copyright
+ =======================================================================================
Review comment:
The License file should not contain information about copyright. Copyright notices go to NOTICE file but only when legally required: https://infra.apache.org/licensing-howto.html#mod-notice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-899048146
That may be a mistake in LICENSE rather than mistaken license header in the file. The original code is at https://github.com/msracver/Deformable-ConvNets/blob/6aeda878a95bcb55eadffbe125804e730574de8d/DCNv2_op/modulated_deformable_convolution.cc and under MIT license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on a change in pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#discussion_r688023527
##########
File path: LICENSE
##########
@@ -284,6 +284,22 @@
3rdparty/openmp
+ =======================================================================================
+ Apache-2.0 license + Microsoft Copyright
+ =======================================================================================
Review comment:
Thanks @leezu so I don't have to call these files out specially right as it is Apache 2.0 licensed?
Also, since we have left copyright of MSFT in these files as is, I don't have call it out in NOTICE file per the link you shared. let me know if this accurate.
From https://infra.apache.org/licensing-howto.html#mod-notice
"Copyright notifications which have been relocated, rather than removed, from source files must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses do not need to be duplicated in NOTICE. You can leave those notices in their original locations."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu edited a comment on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
leezu edited a comment on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-899048146
That may be a mistake in LICENSE rather than mistaken license header in the file. The original code is at https://github.com/msracver/Deformable-ConvNets/blob/6aeda878a95bcb55eadffbe125804e730574de8d/DCNv2_op/modulated_deformable_convolution.cc and under MIT license. "Do not modify or remove any copyright notices or licenses within third-party works." https://www.apache.org/legal/src-headers.html#3party
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898055592
@mxnet-bot run ci [unix-cpu, windows-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898978150
> You removed ` * Licensed under The MIT License` from 5 files in this PR. You can search the string in https://github.com/apache/incubator-mxnet/pull/20520/files
Yes. But those were not listed in License file earlier so no change w.r.t it in License file in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #20520: [v1.9.x][License] Fix redundant ASF and Microsoft Apache 2.0 license files
Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #20520:
URL: https://github.com/apache/incubator-mxnet/pull/20520#issuecomment-898257348
@leezu CI is green. Requesting your review/merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org