You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/23 02:30:17 UTC
[GitHub] [skywalking-kubernetes] innerpeacez opened a new pull request #44:
Makefile fix
innerpeacez opened a new pull request #44: Makefile fix
URL: https://github.com/apache/skywalking-kubernetes/pull/44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #44:
Makefile fix
Posted by GitBox <gi...@apache.org>.
innerpeacez commented on issue #44: Makefile fix
URL: https://github.com/apache/skywalking-kubernetes/pull/44#issuecomment-602463541
done. @wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] wu-sheng commented on a change in pull
request #44: Makefile fix
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #44: Makefile fix
URL: https://github.com/apache/skywalking-kubernetes/pull/44#discussion_r396285708
##########
File path: Makefile
##########
@@ -35,6 +35,8 @@ clean:
rm -rf bin/ \
rm -rf ${CHART_DIR}/NOTICE \
rm -rf ${CHART_DIR}/LICENSE \
+ rm -rf ${CHART_DIR}/Chart.lock \
+ rm -rf ${CHART_DIR}/charts \
Review comment:
Please fix the format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-kubernetes] wu-sheng merged pull request #44: Makefile
fix
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #44: Makefile fix
URL: https://github.com/apache/skywalking-kubernetes/pull/44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services