You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@locus.apache.org on 2000/04/18 04:07:04 UTC

cvs commit: apache-2.0/src/lib/apr/file_io/unix seek.c

trawick     00/04/17 19:07:03

  Modified:    src/lib/apr/file_io/unix seek.c
  Log:
  fix bug setting rc from errno in setptr()
  
  Revision  Changes    Path
  1.12      +1 -1      apache-2.0/src/lib/apr/file_io/unix/seek.c
  
  Index: seek.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/unix/seek.c,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- seek.c	2000/04/14 23:36:13	1.11
  +++ seek.c	2000/04/18 02:07:02	1.12
  @@ -74,7 +74,7 @@
   
           if (rc != -1 ) {
               thefile->bufpos = thefile->dataRead = 0;
  -            rc == errno;
  +            rc = errno;
           }
       }
   
  
  
  

Re: cvs commit: apache-2.0/src/lib/apr/file_io/unix seek.c

Posted by Jeff Trawick <tr...@bellsouth.net>.
Hmmm...  That doesn't look right either.  Maybe it is:

if (rc != -1 ) {
    thefile->bufpos = thefile->dataRead = 0;
}
else {
    rc = errno;
}

I'll drink a little more beer and then look at it again.

>   Index: seek.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/unix/seek.c,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- seek.c	2000/04/14 23:36:13	1.11
>   +++ seek.c	2000/04/18 02:07:02	1.12
>   @@ -74,7 +74,7 @@
>    
>            if (rc != -1 ) {
>                thefile->bufpos = thefile->dataRead = 0;
>   -            rc == errno;
>   +            rc = errno;
>            }
>        }
>    
>   
>   
>   
> 


-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Re: cvs commit: apache-2.0/src/lib/apr/file_io/unix seek.c

Posted by Jeff Trawick <tr...@bellsouth.net>.
Hmmm...  That doesn't look right either.  Maybe it is:

if (rc != -1 ) {
    thefile->bufpos = thefile->dataRead = 0;
}
else {
    rc = errno;
}

I'll drink a little more beer and then look at it again.

>   Index: seek.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/file_io/unix/seek.c,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -r1.11 -r1.12
>   --- seek.c	2000/04/14 23:36:13	1.11
>   +++ seek.c	2000/04/18 02:07:02	1.12
>   @@ -74,7 +74,7 @@
>    
>            if (rc != -1 ) {
>                thefile->bufpos = thefile->dataRead = 0;
>   -            rc == errno;
>   +            rc = errno;
>            }
>        }
>    
>   
>   
>   
> 


-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...