[GitHub] [shardingsphere] azexcy opened a new pull request, #26429: CDC E2E add single table test.

["azexcy (via GitHub)" <gi...@apache.org>]

azexcy opened a new pull request, #26429:
URL: https://github.com/apache/shardingsphere/pull/26429

   
   
   Changes proposed in this pull request:
     - CDC E2E add single table test.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz merged pull request #26429: CDC E2E add single table test.

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz merged PR #26429:
URL: https://github.com/apache/shardingsphere/pull/26429


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #26429: CDC E2E add single table test.

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #26429:
URL: https://github.com/apache/shardingsphere/pull/26429#discussion_r1233589101


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/SingleTableInventoryDataConsistencyChecker.java:
##########
@@ -116,6 +116,14 @@ private DataConsistencyCheckResult check0(final Iterator<DataConsistencyCalculat
         long sourceRecordsCount = 0;
         long targetRecordsCount = 0;
         boolean contentMatched = true;
+        if (sourceCalculatedResults.hasNext() ^ targetCalculatedResults.hasNext()) {
+            if (sourceCalculatedResults.hasNext()) {
+                sourceRecordsCount = waitFuture(executor.submit(sourceCalculatedResults::next)).getRecordsCount();
+            } else {
+                targetRecordsCount = waitFuture(executor.submit(targetCalculatedResults::next)).getRecordsCount();
+            }
+            return new DataConsistencyCheckResult(new DataConsistencyCountCheckResult(sourceRecordsCount, targetRecordsCount), new DataConsistencyContentCheckResult(false));
+        }
         while (sourceCalculatedResults.hasNext() && targetCalculatedResults.hasNext()) {

Review Comment:
   Could we merge this block of code into while loop?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org