You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/17 01:14:35 UTC

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #301: system: nxrecorder: Refactor nxrecorder.c

masayuki2009 opened a new pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301


   ## Summary
   
   - This PR removes redundant code regarding audio buffer configuration in nxrecorder.c
   - The approach is the same as https://github.com/apache/incubator-nuttx-apps/pull/285
   
   ## Impact
   
   - This PR affects nxrecorder.c only
   
   ## Testing
   
   - I tested this PR with spresense:wifi where CONFIG_AUDIO_DRIVER_SPECIFIC_BUFFERS=y
   - To test CONFIG_AUDIO_DRIVER_SPECIFIC_BUFFERS=n case, I had to modify the followings
   
   ```
   --- a/drivers/audio/Kconfig
   +++ b/drivers/audio/Kconfig
   @@ -31,7 +31,6 @@ config AUDIO_CXD56
       bool "CXD56 audio driver"
       default n
       depends on AUDIO
   - select AUDIO_DRIVER_SPECIFIC_BUFFERS
       ---help---
           Enable support for audio playback using the CXD5247 chip on the
           CXD56 Spresense board.
   
   
   --- a/boards/arm/cxd56xx/spresense/configs/wifi/defconfig
   +++ b/boards/arm/cxd56xx/spresense/configs/wifi/defconfig
   @@ -16,15 +16,15 @@ CONFIG_ARCH_CHIP_CXD56XX=y
    CONFIG_ARCH_STACKDUMP=y
    CONFIG_ARMV7M_USEBASEPRI=y
    CONFIG_AUDIO=y
   +CONFIG_AUDIO_BUFFER_NUMBYTES=2048
    CONFIG_AUDIO_CXD56=y
   +CONFIG_AUDIO_NUM_BUFFERS=32
    CONFIG_BOARDCTL_RESET=y
    CONFIG_BOARD_LOOPSPERMSEC=5434
    CONFIG_BOOT_RUNFROMISRAM=y
    CONFIG_BUILTIN=y
    CONFIG_CLOCK_MONOTONIC=y
    CONFIG_CODECS_HASH_MD5=y
   -CONFIG_CXD56_AUDIO_BUFFER_SIZE=2048
   -CONFIG_CXD56_AUDIO_NUM_BUFFERS=32
    CONFIG_CXD56_BINARY=y
    CONFIG_CXD56_DMAC_SPI5_RX=y
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #301: system: nxrecorder: Refactor nxrecorder.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301#issuecomment-645152490


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #301: system: nxrecorder: Refactor nxrecorder.c

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301#issuecomment-645116787


   Hi @xiaoxiang781216,
   
   I refactored nxrecorder.c
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #301: system: nxrecorder: Refactor nxrecorder.c

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #301:
URL: https://github.com/apache/incubator-nuttx-apps/pull/301


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org