You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/15 19:56:56 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6627: stm32g071b-disco: add OLED support
pkarashchenko commented on code in PR #6627:
URL: https://github.com/apache/incubator-nuttx/pull/6627#discussion_r922478251
##########
boards/arm/stm32f0l0g0/stm32g071b-disco/src/stm32g071b-disco.h:
##########
@@ -57,6 +57,17 @@
#define GPIO_JOY_UP (GPIO_INPUT | GPIO_PULLDOWN | GPIO_EXTI | \
GPIO_PORTC | GPIO_PIN4)
+/* OLED definitions *********************************************************/
+
+#define GPIO_SSD1306_CS (GPIO_OUTPUT|GPIO_PUSHPULL|GPIO_SPEED_HIGH| \
+ GPIO_OUTPUT_SET|GPIO_PORTA|GPIO_PIN3)
+
+#define GPIO_SSD1306_CMD (GPIO_OUTPUT|GPIO_PUSHPULL|GPIO_SPEED_HIGH| \
+ GPIO_OUTPUT_SET|GPIO_PORTA|GPIO_PIN7)
+
+#define GPIO_SSD1306_RST (GPIO_OUTPUT|GPIO_PUSHPULL|GPIO_SPEED_HIGH| \
+ GPIO_OUTPUT_SET|GPIO_PORTA|GPIO_PIN6)
Review Comment:
Good to wrap `|` with spaces to follow similar style as in other places
##########
boards/arm/stm32f0l0g0/stm32g071b-disco/include/board.h:
##########
@@ -171,7 +171,7 @@
* SPI1_SCK - PA1
*/
-#undef GPIO_SPI1_MISO /* Not used */
+#define GPIO_SPI1_MISO 0 /* Not used - simplex tx */
Review Comment:
Should "Not used" be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org