You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by ju...@apache.org on 2021/10/25 16:21:04 UTC

[buildstream] branch juerg/integration-cache updated: testing/integration.py: Use module scope for integration_cache fixture

This is an automated email from the ASF dual-hosted git repository.

juergbi pushed a commit to branch juerg/integration-cache
in repository https://gitbox.apache.org/repos/asf/buildstream.git


The following commit(s) were added to refs/heads/juerg/integration-cache by this push:
     new 326f4f3  testing/integration.py: Use module scope for integration_cache fixture
326f4f3 is described below

commit 326f4f39fff08fd3ad6be6514f618aea91a6c393
Author: Jürg Billeter <j...@bitron.ch>
AuthorDate: Mon Oct 25 17:06:14 2021 +0200

    testing/integration.py: Use module scope for integration_cache fixture
    
    Session scope results in multiple IntegrationCache instances being
    created without working cleanup. This can result in excessive disk
    usage, breaking CI on shared GitLab runners.
---
 src/buildstream/testing/integration.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/buildstream/testing/integration.py b/src/buildstream/testing/integration.py
index 662111d..bdca8da 100644
--- a/src/buildstream/testing/integration.py
+++ b/src/buildstream/testing/integration.py
@@ -88,7 +88,7 @@ class IntegrationCache:
             raise AssertionError("Unable to create test directory !") from e
 
 
-@pytest.fixture(scope="session")
+@pytest.fixture(scope="module")
 def integration_cache(request):
     # Set the cache dir to the INTEGRATION_CACHE variable, or the
     # default if that is not set.