You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by ag...@apache.org on 2026/08/31 02:26:35 UTC
(datafusion-comet) branch main updated: chore: remove redundant condition and stray println in shuffle code (#5562)
This is an automated email from the ASF dual-hosted git repository.
andygrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 918bc7d7ac chore: remove redundant condition and stray println in shuffle code (#5562)
918bc7d7ac is described below
commit 918bc7d7ac4123a02ef4bba8ddae920f76db9cbc
Author: Liang-Chi Hsieh <vi...@gmail.com>
AuthorDate: Mon Aug 31 10:26:28 2026 +0800
chore: remove redundant condition and stray println in shuffle code (#5562)
---
.../spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala | 3 +--
.../src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala b/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala
index 32fe282c95..d8f2ef410e 100644
--- a/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala
+++ b/spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala
@@ -551,8 +551,7 @@ object CometShuffleExchangeExec
case StructType(fields) =>
fields.nonEmpty && fields.forall(f => supportedSerializableDataType(f.dataType)) &&
// Java Arrow stream reader cannot work on duplicate field name
- fields.map(f => f.name).distinct.length == fields.length &&
- fields.nonEmpty
+ fields.map(f => f.name).distinct.length == fields.length
case ArrayType(elementType, _) =>
supportedSerializableDataType(elementType)
case MapType(keyType, valueType, _) =>
diff --git a/spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala b/spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala
index 83d185b3d9..e35a547ed9 100644
--- a/spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala
@@ -611,7 +611,6 @@ class CometNativeShuffleSuite extends CometTestBase with AdaptiveSparkPlanHelper
withSQLConf(CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.key -> "true") {
val df = spark.sql("SELECT id, map(id, null) AS m FROM VALUES (1), (2), (3) AS t(id)")
val shuffled = df.repartition(2, $"id")
- println(shuffled.queryExecution.executedPlan)
checkShuffleAnswer(shuffled, 1)
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org