You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ariel Weisberg (JIRA)" <ji...@apache.org> on 2018/09/26 15:09:00 UTC
[jira] [Comment Edited] (CASSANDRA-14762) Transient node receives
full data requests in dtests
[ https://issues.apache.org/jira/browse/CASSANDRA-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628901#comment-16628901 ]
Ariel Weisberg edited comment on CASSANDRA-14762 at 9/26/18 3:08 PM:
---------------------------------------------------------------------
bq. Is this simply you reasoning out the rationale for issuing the requests, or have you spotted an issue with the patch that means we are not doing so?
Sorry it's just socratic code review. I don't see any problems.
+1
Checking locally is nice, but I'm not sure it is as valuable just because the race is much smaller since it's not O(gossip) it's O(time to switch threads).
If you want to do it here or in another ticket it's still good to have.
was (Author: aweisberg):
bq. Is this simply you reasoning out the rationale for issuing the requests, or have you spotted an issue with the patch that means we are not doing so?
Sorry it's just socratic code review. I don't see any problems.
+1
Checking locally is nice, but I'm not sure it is as valuable just because the race is much smaller since it's not O(gossip) it's O(time to switch threads).
> Transient node receives full data requests in dtests
> ----------------------------------------------------
>
> Key: CASSANDRA-14762
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14762
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Ariel Weisberg
> Assignee: Benedict
> Priority: Major
> Fix For: 4.0
>
>
> I saw this running them on my laptop with rapid write protection disabled. Attached is a patch for disabling rapid write protection in the transient dtests.
> {noformat}
> .Exception in thread Thread-19:
> Traceback (most recent call last):
> File "/usr/local/Cellar/python/3.6.4_4/Frameworks/Python.framework/Versions/3.6/lib/python3.6/threading.py", line 916, in _bootstrap_inner
> self.run()
> File "/Users/aweisberg/repos/cassandra-dtest/venv/src/ccm/ccmlib/cluster.py", line 180, in run
> self.scan_and_report()
> File "/Users/aweisberg/repos/cassandra-dtest/venv/src/ccm/ccmlib/cluster.py", line 173, in scan_and_report
> on_error_call(errordata)
> File "/Users/aweisberg/repos/cassandra-dtest/dtest_setup.py", line 137, in _log_error_handler
> pytest.fail("Error details: \n{message}".format(message=message))
> File "/Users/aweisberg/repos/cassandra-dtest/venv/lib/python3.6/site-packages/_pytest/outcomes.py", line 96, in fail
> raise Failed(msg=msg, pytrace=pytrace)
> Failed: Error details:
> Errors seen in logs for: node3
> node3: ERROR [ReadStage-1] 2018-09-18 12:28:48,344 AbstractLocalAwareExecutorService.java:167 - Uncaught exception on thread Thread[ReadStage-1,5,main]
> org.apache.cassandra.exceptions.InvalidRequestException: Attempted to serve transient data request from full node in org.apache.cassandra.db.ReadCommandVerbHandler@3c55e0ff
> at org.apache.cassandra.db.ReadCommandVerbHandler.validateTransientStatus(ReadCommandVerbHandler.java:104)
> at org.apache.cassandra.db.ReadCommandVerbHandler.doVerb(ReadCommandVerbHandler.java:53)
> at org.apache.cassandra.net.MessageDeliveryTask.process(MessageDeliveryTask.java:92)
> at org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:54)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$FutureTask.run(AbstractLocalAwareExecutorService.java:162)
> at org.apache.cassandra.concurrent.AbstractLocalAwareExecutorService$LocalSessionFutureTask.run(AbstractLocalAwareExecutorService.java:134)
> at org.apache.cassandra.concurrent.SEPWorker.run(SEPWorker.java:110)
> at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org