You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/02/22 05:50:22 UTC
[GitHub] merlimat commented on a change in pull request #3658: kerberos
authentication between client and broker
merlimat commented on a change in pull request #3658: kerberos authentication between client and broker
URL: https://github.com/apache/pulsar/pull/3658#discussion_r259219124
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationDataSource.java
##########
@@ -82,39 +83,77 @@ default String getHttpHeader(String name) {
/**
* Check if data from Pulsar protocol are available.
- *
+ *
* @return true if this authentication data contain data from Pulsar protocol
*/
default boolean hasDataFromCommand() {
return false;
}
/**
- *
+ *
* @return authentication data which is stored in a command
*/
default String getCommandData() {
return null;
}
+
+ /*
+ * SASL
+ */
+
+ /**
+ *
+ * @return authentication data which will be stored in a command
+ */
+ default byte[] getCommandDataBytes() {
+ return null;
+ }
+
+ /**
+ * set data which will be stored in a command to send to client
+ * used for sasl.
Review comment:
The interface should not be tied to a specific implementation (eg sasl), but rather abstract the generic needs of multi-step authentication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services