You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/12/03 20:52:18 UTC
Re: Review Request 28467: Move poll based socket implementation into
poll_socket.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28467/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 7:52 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28467/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28467: Move poll based socket implementation into
poll_socket.cpp.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28467/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 12:25 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebase on Master (new network abstractions).
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 75870ac754e500bb4ca689201bde677fa7d854d0
3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 028b33e7ecb7e0a39334ac4ab0279ee327a72a56
Diff: https://reviews.apache.org/r/28467/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28467: Move poll based socket implementation into
poll_socket.cpp.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28467/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 11:41 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Add config.hpp for MSG_NOSIGNAL (OSX).
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28467/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28467: Move poll based socket implementation into
poll_socket.cpp.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28467/#review63723
-----------------------------------------------------------
Ship it!
Taken it's a code move
3rdparty/libprocess/src/poll_socket.cpp
<https://reviews.apache.org/r/28467/#comment106009>
This will probably break on Mac OS X - take a look in config.hpp for MSG_NOSIGNAL. Think you need to include it :-)
- Niklas Nielsen
On Dec. 3, 2014, 11:52 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28467/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 11:52 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
> 3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
>
> Diff: https://reviews.apache.org/r/28467/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>