You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/14 04:17:37 UTC
[GitHub] [pulsar] casuallc opened a new pull request, #17631: [17630] Fix - Close ledger after schema data write.
casuallc opened a new pull request, #17631:
URL: https://github.com/apache/pulsar/pull/17631
### Motivation
#17630
### Modifications
Close ledger after addEntry.
### Verifying this change
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] casuallc commented on pull request #17631: [fix][broker] Close ledger after schema data write.
Posted by GitBox <gi...@apache.org>.
casuallc commented on PR #17631:
URL: https://github.com/apache/pulsar/pull/17631#issuecomment-1246426951
> Why need to close the ledger?
If bk stoped, schema ledger recover would be failed. I do not konwn why ... Is there something not flush to zk node `/ledger/00/0000/L`?
`bin/pulsar-admin schemas get topic` will trigger ledger fenced, so I think is ok to close ledger after write schema entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #17631: [fix][broker] Close ledger after schema data write.
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on PR #17631:
URL: https://github.com/apache/pulsar/pull/17631#issuecomment-1246407209
Why need to close the ledger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17631: [17630] Fix - Close ledger after schema data write.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17631:
URL: https://github.com/apache/pulsar/pull/17631#issuecomment-1246219962
@casuallc Please provide a correct documentation label for your PR.
Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17631: [fix][broker] Close ledger after schema data write.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17631:
URL: https://github.com/apache/pulsar/pull/17631#issuecomment-1284820729
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org