You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/09/30 06:55:16 UTC
[PR] fix: treat numRows zero as unlimited [fesod]
Aias00 opened a new pull request, #1159:
URL: https://github.com/apache/fesod/pull/1159
Fixes #1149
## Summary
- make numRows(0) follow the documented unlimited behavior
- cover workbook-level and sheet-level numRows(0) reads across formats
## Verification
- ./mvnw -pl fesod-sheet -Dmaven.test.skip=false -DskipTests=false -Dtest=ParameterDataTest#numRowsZeroReadsAllRows test
- ./mvnw -pl fesod-sheet spotless:check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] fix: treat numRows zero as unlimited [fesod]
Posted by "BigDataDZ (via GitHub)" <gi...@apache.org>.
BigDataDZ commented on PR #1159:
URL: https://github.com/apache/fesod/pull/1159#issuecomment-6073080508
Small suggestion from a fellow traveler on #1149 (my overlapping #1189 — closing it in favor of this one, the core guard is identical). While testing I also covered two neighboring cases that might be worth guarding here: `numRows` omitted entirely (must keep reading all rows) and a positive limit (must still stop early), plus a headless-sheet setup so the limit maps 1:1 onto data rows. Happy to send these as a follow-up PR if useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org