You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/06/27 11:53:01 UTC
[jira] [Commented] (IMPALA-8476) Replace Sentry admin check
workaround with proper Sentry API
[ https://issues.apache.org/jira/browse/IMPALA-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874039#comment-16874039 ]
ASF subversion and git services commented on IMPALA-8476:
---------------------------------------------------------
Commit ee2b3b9bfaf7950a8fb3f87ea44c29d0f6a13be4 in impala's branch refs/heads/master from Fang-Yu Rao
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ee2b3b9 ]
IMPALA-8476: Replace Sentry admin check workaround with proper Sentry API
Impala uses a workaround to detect if a user is a Sentry admin by calling
the Sentry API to list privileges associated with the user since previously
Sentry did not provide a suitable API to peform this check.
This patch invokes a new API in SENTRY-2440 to perform the Sentry admin check.
Also modified test_sentry.py to exercise the code paths corresponding to the
following 3 different types of users: (i) a Sentry admin, (ii) an existing
user which is not a Sentry admin, and (iii) a non-existing user.
Testing:
1. Passed the tests in the revised test_sentry.py.
Change-Id: I5a27140d401494bc372ad0da96ada57bda94cd82
Reviewed-on: http://gerrit.cloudera.org:8080/13346
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Replace Sentry admin check workaround with proper Sentry API
> ------------------------------------------------------------
>
> Key: IMPALA-8476
> URL: https://issues.apache.org/jira/browse/IMPALA-8476
> Project: IMPALA
> Issue Type: Improvement
> Components: Catalog
> Reporter: Fredy Wijaya
> Assignee: Fang-Yu Rao
> Priority: Minor
> Labels: newbie
> Fix For: Impala 3.3.0
>
>
> Impala uses a workaround to detect if a user is a Sentry admin by calling list privileges API before Sentry didn't provide an API to tell if user is a Sentry admin: https://github.com/apache/impala/blob/d820952d86d34ba887c55a09e58b735cbef866c2/fe/src/main/java/org/apache/impala/authorization/sentry/SentryProxy.java#L378-L393
> https://issues.apache.org/jira/browse/SENTRY-2440 supports a new API. We should update the Impala to use the new proper Sentry API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org