You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2014/12/13 16:54:37 UTC
wicket git commit: No functional change. Added some todos in JavaDoc
to mark those classes and methods that can be replaced in Wicket 8 with
standard Java 8 classes and methods.
Repository: wicket
Updated Branches:
refs/heads/master 25f7d433e -> 1bcb02e95
No functional change. Added some todos in JavaDoc to mark those classes
and methods that can be replaced in Wicket 8 with standard Java 8
classes and methods.
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1bcb02e9
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1bcb02e9
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1bcb02e9
Branch: refs/heads/master
Commit: 1bcb02e956071ba5754128d6c4d93d2ed7a67ea2
Parents: 25f7d43
Author: Andrea Del Bene <ad...@apache.org>
Authored: Sat Dec 13 16:53:48 2014 +0100
Committer: Andrea Del Bene <ad...@apache.org>
Committed: Sat Dec 13 16:53:48 2014 +0100
----------------------------------------------------------------------
.../src/main/java/org/apache/wicket/util/IProvider.java | 3 +++
.../src/main/java/org/apache/wicket/util/crypt/Base64.java | 2 ++
.../src/main/java/org/apache/wicket/util/string/Strings.java | 6 ++++++
3 files changed, 11 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
index aeb9f8b..67822e5 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
@@ -19,6 +19,9 @@ package org.apache.wicket.util;
/**
* An object that can provide instances of type {@code T}
*
+ * TODO Wicket 8: consider to deprecate this interface in Wicket 7 and replace it with standard
+ * Java 8 {@code java.util.function.Supplier<T>} which is virtually identical.
+ *
* @author igor.vaynberg
* @param <T>
*/
http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
index 74e769b..d8b5dcc 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
@@ -34,6 +34,8 @@ import java.math.BigInteger;
* Josefsson.
* </p>
*
+ * TODO Wicket 8: consider to deprecate this class in Wicket 7 and replace it with standard Java 8 {@code java.util.Base64}
+ *
* @author Apache Software Foundation
* @author Juergen Donnerstag
*
http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
index 54d5eb5..ac9707b 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
@@ -629,6 +629,9 @@ public final class Strings
/**
* Joins string fragments using the specified separator
*
+ * TODO Wicket 8: consider to deprecate this method in Wicket 7 and replace it with standard
+ * Java 8 {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)}
+ *
* @param separator
* @param fragments
* @return combined fragments
@@ -646,6 +649,9 @@ public final class Strings
/**
* Joins string fragments using the specified separator
*
+ * TODO Wicket 8: consider to deprecate this method in Wicket 7 and replace it with standard
+ * Java 8 {@code String#join(CharSequence delimiter, CharSequence... elements)}
+ *
* @param separator
* @param fragments
* @return combined fragments
Re: wicket git commit: No functional change. Added some todos in
JavaDoc to mark those classes and methods that can be replaced in Wicket 8
with standard Java 8 classes and methods.
Posted by Martin Grigorov <mg...@apache.org>.
Hi Andrea,
These shouldn't be part of the Javadoc.
Move them after the /** */ comments either as
/* TODO ... */
or
// TODO ..
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sat, Dec 13, 2014 at 5:54 PM, <ad...@apache.org> wrote:
>
> Repository: wicket
> Updated Branches:
> refs/heads/master 25f7d433e -> 1bcb02e95
>
>
> No functional change. Added some todos in JavaDoc to mark those classes
> and methods that can be replaced in Wicket 8 with standard Java 8
> classes and methods.
>
> Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
> Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1bcb02e9
> Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1bcb02e9
> Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1bcb02e9
>
> Branch: refs/heads/master
> Commit: 1bcb02e956071ba5754128d6c4d93d2ed7a67ea2
> Parents: 25f7d43
> Author: Andrea Del Bene <ad...@apache.org>
> Authored: Sat Dec 13 16:53:48 2014 +0100
> Committer: Andrea Del Bene <ad...@apache.org>
> Committed: Sat Dec 13 16:53:48 2014 +0100
>
> ----------------------------------------------------------------------
> .../src/main/java/org/apache/wicket/util/IProvider.java | 3 +++
> .../src/main/java/org/apache/wicket/util/crypt/Base64.java | 2 ++
> .../src/main/java/org/apache/wicket/util/string/Strings.java | 6 ++++++
> 3 files changed, 11 insertions(+)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
> b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
> index aeb9f8b..67822e5 100755
> --- a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
> +++ b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
> @@ -19,6 +19,9 @@ package org.apache.wicket.util;
> /**
> * An object that can provide instances of type {@code T}
> *
> + * TODO Wicket 8: consider to deprecate this interface in Wicket 7 and
> replace it with standard
> + * Java 8 {@code java.util.function.Supplier<T>} which is virtually
> identical.
> + *
> * @author igor.vaynberg
> * @param <T>
> */
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
> b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
> index 74e769b..d8b5dcc 100644
> --- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
> +++ b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
> @@ -34,6 +34,8 @@ import java.math.BigInteger;
> * Josefsson.
> * </p>
> *
> + * TODO Wicket 8: consider to deprecate this class in Wicket 7 and
> replace it with standard Java 8 {@code java.util.Base64}
> + *
> * @author Apache Software Foundation
> * @author Juergen Donnerstag
> *
>
>
> http://git-wip-us.apache.org/repos/asf/wicket/blob/1bcb02e9/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
> ----------------------------------------------------------------------
> diff --git
> a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
> b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
> index 54d5eb5..ac9707b 100755
> --- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
> +++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
> @@ -629,6 +629,9 @@ public final class Strings
> /**
> * Joins string fragments using the specified separator
> *
> + * TODO Wicket 8: consider to deprecate this method in Wicket 7
> and replace it with standard
> + * Java 8 {@code String#join(CharSequence delimiter, Iterable<?
> extends CharSequence> elements)}
> + *
> * @param separator
> * @param fragments
> * @return combined fragments
> @@ -646,6 +649,9 @@ public final class Strings
> /**
> * Joins string fragments using the specified separator
> *
> + * TODO Wicket 8: consider to deprecate this method in Wicket 7
> and replace it with standard
> + * Java 8 {@code String#join(CharSequence delimiter,
> CharSequence... elements)}
> + *
> * @param separator
> * @param fragments
> * @return combined fragments
>
>