You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@opennlp.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/27 18:42:24 UTC

[jira] [Commented] (OPENNLP-969) Trainers should have a Constructor that takes a TrainingParamer

    [ https://issues.apache.org/jira/browse/OPENNLP-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843307#comment-15843307 ] 

ASF GitHub Bot commented on OPENNLP-969:
----------------------------------------

GitHub user danielruss opened a pull request:

    https://github.com/apache/opennlp/pull/95

    OPENNLP-969:Added constructor to trainers that takes a TrainingParameter

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielruss/opennlp OpenNLP-969

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 587b6e512de249e770c724da1380d880e0c1bc2a
Author: Daniel Russ <dr...@mail.nih.gov>
Date:   2017-01-27T18:41:00Z

    OPENNLP-969:Added constructor to trainers that takes a TrainingParameter

----


> Trainers should have a Constructor that takes a TrainingParamer
> ---------------------------------------------------------------
>
>                 Key: OPENNLP-969
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-969
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Machine Learning
>    Affects Versions: 1.7.1
>            Reporter: Russ, Daniel (NIH/CIT) [E]
>            Priority: Minor
>             Fix For: 1.7.2
>
>
> Every time we construct a trainer, we construct, then init. Have an optional Constructor that takes a TrainingParameter and calls the init method. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)