[jira] [Commented] (AVRO-533) .NET implementation of Avro

["Dona Alvarez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009818#comment-13009818 ] 

Dona Alvarez commented on AVRO-533:
-----------------------------------


Thiru,

Thanks for looking into it. Please see my answers below:


■Two unit tests failed. (TestResolutionMismatch_simple of GenericTests and SpecificTests). They failed because lines 123 to 126 in GenericReader.cs were commented out. Uncommenting that fixes the problem.

- I moved the CanRead() call to Read<T>() since calling CanRead() from the top level schema recursively calls CanRead() for all its child schemas so it doesn't need to be repeated inside the read() function, with the exception of union schema. I added a call to CanRead inside ReadUnion() and that took care of the unit test issue. Let me know if you think I'm missing something here by making this change. Also, there is a big performance gain by doing it this way.

■The test for codegen has its assertions commented out. Uncommenting it still succeeds, I'm not sure why they are commented. But still, I get an impression that the tests there is inadequate. It merely tests that compilation of the generated code goes through. It doesn't seem to test the contents of generated code.

- I commented it out becase for some reason I am still missing a reference to a system assembly so the compilation always errors out. I haven't had the chance to get back to it. I also have not added all my code gen test cases into Nunit. 

■Perhaps I'm missing something completely. To me, SpecificTests seems to test Generic rather than Specific. What am I missing?

- Yes, SpecificTests is just a copy of Generic. My testcases for this are not yet integrated in Nunit.

■Protocol compiler is in place. But there is no server or client implementation. This is fine, but I just wanted to check if my understanding is correct.

- Correct, at this point we (my company) only needed a protocol parser.

Thanks,
Dona


> .NET implementation of Avro
> ---------------------------
>
>                 Key: AVRO-533
>                 URL: https://issues.apache.org/jira/browse/AVRO-533
>             Project: Avro
>          Issue Type: New Feature
>    Affects Versions: 1.4.0
>            Reporter: Jeff Hammerbacher
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-533.patch, AVRO-533.patch, AVRO-533.zip, csharp.zip, csharp_2nd_patch.zip, dotnet.patch, failure.txt
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira