You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/09/19 22:58:45 UTC
[GitHub] [maven-surefire] fl4via opened a new pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
fl4via opened a new pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391
…rInFork
Jira: https://issues.apache.org/jira/browse/SUREFIRE-1946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on a change in pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#discussion_r775575790
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
##########
@@ -653,6 +653,12 @@ private RunResult fork( Object testSet, PropertiesWrapper providerProperties, Fo
{
runResult = timeout( reporter.getGlobalRunStatistics().getRunResult() );
}
+ else if ( forkClient.isErrorInFork() )
+ {
+ final StackTraceWriter stackTrace = forkClient.getErrorInFork();
+ booterForkException =
+ new SurefireBooterForkException( stackTrace.writeTraceToString() );
+ }
Review comment:
Please look line 711 - 733
StackTrace is printed if Maven command is started with -e option
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] fl4via commented on pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
Posted by GitBox <gi...@apache.org>.
fl4via commented on pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#issuecomment-922550449
I'm not sure if this fix is the best approach, and if there is need for a test, but this fix at least solved the problem in my reproducer, allowing me to see the stack trace of the error that generated the fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on a change in pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#discussion_r789266542
##########
File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
##########
@@ -653,6 +653,12 @@ private RunResult fork( Object testSet, PropertiesWrapper providerProperties, Fo
{
runResult = timeout( reporter.getGlobalRunStatistics().getRunResult() );
}
+ else if ( forkClient.isErrorInFork() )
+ {
+ final StackTraceWriter stackTrace = forkClient.getErrorInFork();
+ booterForkException =
+ new SurefireBooterForkException( stackTrace.writeTraceToString() );
+ }
Review comment:
@fl4via
Pls have a look at the comments and answers. How can we continue with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] fl4via edited a comment on pull request #391: [SUREFIRE-1946] At ForkStarter.fork, treat the case forkClient.isErro…
Posted by GitBox <gi...@apache.org>.
fl4via edited a comment on pull request #391:
URL: https://github.com/apache/maven-surefire/pull/391#issuecomment-922550449
I'm not sure if this fix is the best approach, and if there is need for a test, but this fix at least solved the problem in my reproducer, allowing me to see the stack trace of the fork error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org