[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #7987: KVM Agent config to reserve dom0 CPUs

["GutoVeronezi (via GitHub)" <gi...@apache.org>]

GutoVeronezi commented on code in PR #7987:
URL: https://github.com/apache/cloudstack/pull/7987#discussion_r1331981042


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -452,6 +452,8 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
 
     private long _dom0OvercommitMem;
 
+    private int _dom0MinCpuCores;

Review Comment:
   ```suggestion
       private int dom0MinCpuCores;
   ```
   
   The `_` is a legacy pattern; it should not be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org