You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Guenter Knauf <fu...@apache.org> on 2011/03/20 09:47:08 UTC

where is dav_get_limit_xml_body?

I was just testing if I could automatically create an export list for 
mod_dav when I found this in mod_dav.h:

/* --------------------------------------------------------------------
**
** MISCELLANEOUS STUFF
*/

/* fetch the "LimitXMLRequestBody" in force for this resource */
DAV_DECLARE(apr_size_t) dav_get_limit_xml_body(const request_rec *r);

which source file should this function provide? I did search through the 
whole source tree, but couldnt find any other reference to this symbol ...
(BTW. same is in 2.2.x branch too)

Gün.



Re: where is dav_get_limit_xml_body?

Posted by Guenter Knauf <fu...@apache.org>.
Greg,
Am 20.03.2011 17:50, schrieb Greg Stein:
> The function name is probably obsolete. I'm away from my laptop, so can't
> find the answer. Search the source for that Limit directive mentioned, and
> work out from there. I think I moved it out of mod_dav into a more generic
> location
did that already - see also my 2nd post:
http://svn.apache.org/viewvc?view=revision&revision=85816
seems that you just forgot to remove the dav_get_limit_xml_body() 
prototype from mod_dav.h with this commit ...
do you agree that I remove it now?

thanks, Gün.



Re: where is dav_get_limit_xml_body?

Posted by Greg Stein <gs...@gmail.com>.
The function name is probably obsolete. I'm away from my laptop, so can't
find the answer. Search the source for that Limit directive mentioned, and
work out from there. I think I moved it out of mod_dav into a more generic
location
On Mar 20, 2011 8:47 AM, "Guenter Knauf" <fu...@apache.org> wrote:
> I was just testing if I could automatically create an export list for
> mod_dav when I found this in mod_dav.h:
>
> /* --------------------------------------------------------------------
> **
> ** MISCELLANEOUS STUFF
> */
>
> /* fetch the "LimitXMLRequestBody" in force for this resource */
> DAV_DECLARE(apr_size_t) dav_get_limit_xml_body(const request_rec *r);
>
> which source file should this function provide? I did search through the
> whole source tree, but couldnt find any other reference to this symbol ...
> (BTW. same is in 2.2.x branch too)
>
> Gün.
>
>

Re: where is dav_get_limit_xml_body?

Posted by Greg Stein <gs...@gmail.com>.
On Sun, Mar 20, 2011 at 14:59, Guenter Knauf <fu...@apache.org> wrote:
> Am 20.03.2011 19:41, schrieb William A. Rowe Jr.:
>>
>> Go ahead and simply remove it, just as the docs team would backport
>> whatever
>> documentation cleanup was appropriate without a STATUS dance.  No code is
>> actually harmed in this exercise.
>
> done:
> http://svn.apache.org/viewvc?rev=1083536&view=rev

Cool. Thanks for the (late) cleanup! :-P

Cheers,
-g

Re: where is dav_get_limit_xml_body?

Posted by Guenter Knauf <fu...@apache.org>.
Am 20.03.2011 19:41, schrieb William A. Rowe Jr.:
> Go ahead and simply remove it, just as the docs team would backport whatever
> documentation cleanup was appropriate without a STATUS dance.  No code is
> actually harmed in this exercise.
done:
http://svn.apache.org/viewvc?rev=1083536&view=rev

Gün.




Re: where is dav_get_limit_xml_body?

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 3/20/2011 10:39 AM, Guenter Knauf wrote:
> Am 20.03.2011 09:47, schrieb Guenter Knauf:
>> I was just testing if I could automatically create an export list for
>> mod_dav when I found this in mod_dav.h:
>>
>> /* --------------------------------------------------------------------
>> **
>> ** MISCELLANEOUS STUFF
>> */
>>
>> /* fetch the "LimitXMLRequestBody" in force for this resource */
>> DAV_DECLARE(apr_size_t) dav_get_limit_xml_body(const request_rec *r);
>>
>> which source file should this function provide? I did search through the
>> whole source tree, but couldnt find any other reference to this symbol ...
>> (BTW. same is in 2.2.x branch too)
> digged some deeper, and found this commit:
> http://svn.apache.org/viewvc?view=revision&revision=85816
> to me it looks like it was just forgotten to remove the dav_get_limit_xml_body() prototype
> from mod_dav.h with this commit ...
> if nobody objects I will remove it tommorow, and propose the backport.

Go ahead and simply remove it, just as the docs team would backport whatever
documentation cleanup was appropriate without a STATUS dance.  No code is
actually harmed in this exercise.



Re: where is dav_get_limit_xml_body?

Posted by Guenter Knauf <fu...@apache.org>.
Am 20.03.2011 09:47, schrieb Guenter Knauf:
> I was just testing if I could automatically create an export list for
> mod_dav when I found this in mod_dav.h:
>
> /* --------------------------------------------------------------------
> **
> ** MISCELLANEOUS STUFF
> */
>
> /* fetch the "LimitXMLRequestBody" in force for this resource */
> DAV_DECLARE(apr_size_t) dav_get_limit_xml_body(const request_rec *r);
>
> which source file should this function provide? I did search through the
> whole source tree, but couldnt find any other reference to this symbol ...
> (BTW. same is in 2.2.x branch too)
digged some deeper, and found this commit:
http://svn.apache.org/viewvc?view=revision&revision=85816
to me it looks like it was just forgotten to remove the 
dav_get_limit_xml_body() prototype from mod_dav.h with this commit ...
if nobody objects I will remove it tommorow, and propose the backport.

Gün.