[GitHub] [spark] jiangxb1987 commented on a change in pull request #29276: [SPARK-32470][CORE] Remove task result size check for shuffle map stage

[GitBox <gi...@apache.org>]

jiangxb1987 commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r462572658



##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
   def canFetchMoreResults(size: Long): Boolean = sched.synchronized {
     totalResultSize += size
     calculatedTasks += 1
-    if (maxResultSize > 0 && totalResultSize > maxResultSize) {
+    if (!isShuffleMapTasks && maxResultSize > 0 && totalResultSize > maxResultSize) {

Review comment:
       LGTM too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org