You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jonathan Keane (Jira)" <ji...@apache.org> on 2022/04/08 19:34:00 UTC
[jira] [Updated] (ARROW-16158) [C++] rename ARROW_ENGINE to ARROW_SUBSTRAIT
[ https://issues.apache.org/jira/browse/ARROW-16158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Keane updated ARROW-16158:
-----------------------------------
Priority: Blocker (was: Major)
> [C++] rename ARROW_ENGINE to ARROW_SUBSTRAIT
> --------------------------------------------
>
> Key: ARROW-16158
> URL: https://issues.apache.org/jira/browse/ARROW-16158
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Jonathan Keane
> Priority: Blocker
>
> When we introduced substrait we reused the cmake + feature {{ARROW_ENGINE}} to mean compute+a few other things as well as the substrait consumer functionality. In general, right now, we don't yet need (or want) to build substrait in our packages (e.g. the R package) since many places don't yet take advantage of it. But the naming of the cmake or feature is now confusing: it effectively is only substrait if you separately enable copmute, etc. but it makes it sound like the query engine we have been building since 6.0.0 is disabled.
> We should rename {{ARROW_ENGINE}} to {{ARROW_SUBSTRAIT}} now and then we can add an {{ARROW_ENGINE}} later if we need to encompass a larger set of engine functionality (e.g. compute+spillover+scheduler+memory limits) if that's needed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)