You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bigtop.apache.org by se...@apache.org on 2021/03/17 23:34:14 UTC
[bigtop] branch master updated: BIGTOP-3527: replace ${PWD} with
${CURDIR} in debian rules files (#760)
This is an automated email from the ASF dual-hosted git repository.
sekikn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bigtop.git
The following commit(s) were added to refs/heads/master by this push:
new 0351fda BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files (#760)
0351fda is described below
commit 0351fdac364d3182ec26df8364ccfb49774df15f
Author: Luca Toscano <el...@users.noreply.github.com>
AuthorDate: Thu Mar 18 00:34:05 2021 +0100
BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files (#760)
According to
https://lintian.debian.org/tags/debian-rules-calls-pwd.html,
CURDIR is the preferred way in a makefile (like rules) to refer to the
current directory. For some reason I got building failures when running
a Debian 10 bigtop docker imagei and trying to build the hadoop pkg,
that got solved only applying this fix.
Applied the same fix to all the debian rules files with ${PWD}.
---
bigtop-packages/src/deb/gpdb/rules | 2 +-
bigtop-packages/src/deb/hadoop/rules | 4 ++--
bigtop-packages/src/deb/phoenix/rules | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bigtop-packages/src/deb/gpdb/rules b/bigtop-packages/src/deb/gpdb/rules
index ec85f87..31bac46 100755
--- a/bigtop-packages/src/deb/gpdb/rules
+++ b/bigtop-packages/src/deb/gpdb/rules
@@ -37,7 +37,7 @@ override_dh_auto_build:
override_dh_auto_install:
install -d -p -m 755 debian/gpdb
- bash -x debian/install_gpdb.sh ${PWD}/debian/gpdb
+ bash -x debian/install_gpdb.sh ${CURDIR}/debian/gpdb
override_dh_auto_test:
@echo Tests are disabled
diff --git a/bigtop-packages/src/deb/hadoop/rules b/bigtop-packages/src/deb/hadoop/rules
index e5761b7..6f6d4c0 100755
--- a/bigtop-packages/src/deb/hadoop/rules
+++ b/bigtop-packages/src/deb/hadoop/rules
@@ -56,7 +56,7 @@ override_dh_auto_install:
bash debian/install_hadoop.sh \
--prefix=debian/tmp/ \
--distro-dir=debian \
- --build-dir=${PWD}/build \
+ --build-dir=${CURDIR}/build \
--system-lib-dir=debian/tmp/usr/lib/ \
--system-libexec-dir=debian/tmp/usr/lib/hadoop/libexec/ \
--system-include-dir=debian/tmp/usr/include \
@@ -81,7 +81,7 @@ override_dh_auto_install:
override_dh_install: $(hadoop_svcs)
dh_install
# Drop misc fuse_dfs directories
- rm -Rf debian/hadoop/usr/lib/hadoop/bin/fuse_dfs
+ rm -Rf debian/hadoop/usr/lib/hadoop/bin/fuse_dfs
rm -Rf debian/hadoop/usr/lib/hadoop/contrib/fuse-dfs
rm -Rf debian/hadoop/usr/lib/hadoop/hdfs/contrib/fuse-dfs
diff --git a/bigtop-packages/src/deb/phoenix/rules b/bigtop-packages/src/deb/phoenix/rules
index 4a44f93..33c8676 100755
--- a/bigtop-packages/src/deb/phoenix/rules
+++ b/bigtop-packages/src/deb/phoenix/rules
@@ -41,5 +41,5 @@ override_dh_auto_build:
override_dh_auto_install:
bash -x debian/install_phoenix.sh \
- --build-dir=$${PWD}/build \
+ --build-dir=${CURDIR}/build \
--prefix=debian/tmp