[jira] [Commented] (ZOOKEEPER-2611) zoo_remove_watchers - can remove the wrong watch

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560101#comment-15560101 ] 

Hadoop QA commented on ZOOKEEPER-2611:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12832348/ZOOKEEPER-2611.patch
  against trunk revision df5519ab9dac9940f35cc4b308b560f2603aec7f.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3473//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3473//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3473//console

This message is automatically generated.

> zoo_remove_watchers - can remove the wrong watch 
> -------------------------------------------------
>
>                 Key: ZOOKEEPER-2611
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2611
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: Eyal leshem
>            Priority: Critical
>         Attachments: ZOOKEEPER-2611.patch
>
>
> The actual problem is in the function "removeWatcherFromList" - 
> That when we check if we need to delete the watch -  we compare the WatcherCtx to one node before the one we want to delete.. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)