You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/07 14:25:21 UTC
[GitHub] [hudi] UZi5136225 opened a new pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
UZi5136225 opened a new pull request #1931:
URL: https://github.com/apache/hudi/pull/1931
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
hudi support prometheus/pushgateway
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 removed a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 removed a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671294907
Please use <include></include> and try to recompile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671296120
I'm sorry, i dont get it. I use `mvn clean package -DskipTests -DskipITs -Dscala-2.12` for compilation. What do you mean by
> Please use 'include'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer edited a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer edited a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671353265
@UZi5136225 i just noticed that i get a `java.lang.ClassNotFoundException: io.prometheus.client.exporter.common.TextFormat` when trying to access the interface. I think we should also add (i will give it a try)
```
<include>io.prometheus:simpleclient_common</include>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671294907
Please use <include></include> and try to recompile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-675804567
Right Prometheus does not support, these are specially made for pushgateway
@sbernauer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671302048
If you use the include tag to include the required dependencies, it should be correct. Let me see why
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 removed a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 removed a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671297401
Try the following packages you need
<include>io.prometheus:simpleclient_pushgateway</include>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671336381
https://github.com/apache/hudi/pull/1942 @sbernauer You can try this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671350777
Thanks @UZi5136225, this fixed the problem!
I dont understand why, because i added all the libs below in the correct version to the classpath. But it works :)
```
mvn dependency:tree | grep simpleclient
[INFO] +- io.prometheus:simpleclient:jar:0.8.0:compile
[INFO] +- io.prometheus:simpleclient_httpserver:jar:0.8.0:compile
[INFO] | \- io.prometheus:simpleclient_common:jar:0.8.0:compile
[INFO] +- io.prometheus:simpleclient_dropwizard:jar:0.8.0:compile
[INFO] +- io.prometheus:simpleclient_pushgateway:jar:0.8.0:compile
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 removed a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 removed a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671295024
Please use '<include></include>' and try to recompile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671334282
Thanks a lot @UZi5136225 for your fast response!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670584668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671299385
The constructor of DropwizardExports seems to be stable and I'm wondering what is going wrong here (It does not seem like a version mismatch to me). https://github.com/prometheus/client_java/blob/570f8bb70ae6f5a0a950dc563b68fb495d2f4d69/simpleclient_dropwizard/src/main/java/io/prometheus/client/dropwizard/DropwizardExports.java#L30
Mabye `org/apache/hudi/com/codahale/metrics/MetricRegistry` (see exception) instead of `com/codahale/metrics/MetricRegistry` is a problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671288581
Hi, thanks for this PR!
I added `simpleclient-0.8.0.jar` `simpleclient_dropwizard-0.8.0.jar` `simpleclient_httpserver-0.8.0.jar` and `simpleclient_pushgateway-0.8.0.jar` to the classpath. If i try to use the prometheus exporter i get the following error. Do you know why this happens?
```
Caused by: java.lang.NoSuchMethodError: io.prometheus.client.dropwizard.DropwizardExports.<init>(Lorg/apache/hudi/com/codahale/metrics/MetricRegistry;)V
at org.apache.hudi.metrics.prometheus.PrometheusReporter.<init>(PrometheusReporter.java:49)
at org.apache.hudi.metrics.MetricsReporterFactory.createReporter(MetricsReporterFactory.java:75)
at org.apache.hudi.metrics.Metrics.<init>(Metrics.java:45)
at org.apache.hudi.metrics.Metrics.init(Metrics.java:73)
at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamerMetrics.<init>(HoodieDeltaStreamerMetrics.java:44)
at org.apache.hudi.utilities.deltastreamer.DeltaSync.syncOnce(DeltaSync.java:227)
at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer$DeltaSyncService.lambda$startService$0(HoodieDeltaStreamer.java:579)
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670583885
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671291562
Are you using deltastreamer?
Use <include></include> to recompile and try again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671298448
My setup has no access to the internet, so i downloaded the libs from mvn central and included them in my docker images. Is the version 0.8.0 correct?
```
$ ls simpleclient*
simpleclient-0.8.0.jar simpleclient_common-0.8.0.jar simpleclient_dropwizard-0.8.0.jar simpleclient_httpserver-0.8.0.jar simpleclient_pushgateway-0.8.0.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671301067
If i uncompress my `simpleclient_dropwizard-0.8.0.jar` and look inside the class all seems correct:
```
$ javap DropwizardExports.class
Compiled from "DropwizardExports.java"
public class io.prometheus.client.dropwizard.DropwizardExports extends io.prometheus.client.Collector implements io.prometheus.client.Collector$Describable {
public io.prometheus.client.dropwizard.DropwizardExports(com.codahale.metrics.MetricRegistry);
public io.prometheus.client.dropwizard.DropwizardExports(com.codahale.metrics.MetricRegistry, io.prometheus.client.dropwizard.samplebuilder.SampleBuilder);
[...]
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer edited a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer edited a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671294110
Yes, im using deltastreamer, freshly compiled from source of the master branch.
The new config:
```
hoodie.metrics.on=true
hoodie.metrics.reporter.type=PROMETHEUS
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer edited a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer edited a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671304318
I don't use the include option but instead guarantee that all drivers and executors have the libs and correctly use them via SPARK_DIST_CLASSPATH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671354955
Yes, this configuration needs to be added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671297746
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671304318
I don't use the include, option but instead guarantee that all drivers and executors have the libs and correctly use them via SPARK_DIST_CLASSPATH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671331840
It’s because I missed to configure less dependencies, it will be fixed soon
@sbernauer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670830555
rerun tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671295024
Please use '<include></include>' and try to recompile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer edited a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer edited a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671353265
@UZi5136225 i just noticed that i get a `java.lang.ClassNotFoundException: io.prometheus.client.exporter.common.TextFormat` when trying to access the interface. I think we should also add
```
<include>io.prometheus:simpleclient_common</include>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671295304
Please use 'include'
and try to recompile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671297401
Try the following packages you need
<include>io.prometheus:simpleclient_pushgateway</include>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf merged pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1931:
URL: https://github.com/apache/hudi/pull/1931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671294110
Yes, im using deltastreamer, freshly compiled from source of the master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670594131
@leesf Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671353265
@UZi5136225 i just noticed taht i get a `java.lang.ClassNotFoundException: io.prometheus.client.exporter.common.TextFormat` when trying to access the interface. I think we should also add
```
<include>io.prometheus:simpleclient_common</include>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer edited a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer edited a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671296120
I'm sorry, i dont get it. I use `mvn clean package -DskipTests -DskipITs -Dscala-2.12` for compilation. What do you mean by
> Please use 'include'
Edit: Oh you mean adding the scope include in the pom for the 4 dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-675519379
> Hi @UZi5136225 it is currently not possible to set the metric with `hoodie.metrics.prometheus.metric.prefix`. Is this intended?
@UZi5136225 would you please take a look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670584994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 removed a comment on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 removed a comment on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670584668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] sbernauer commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
sbernauer commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-674871980
Hi @UZi5136225 it is currently not possible to set the metric with `hoodie.metrics.prometheus.metric.prefix`. Is this intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] leesf commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
leesf commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-670820501
rerun tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] UZi5136225 commented on pull request #1931: [HUDI-210] hudi-support-prometheus-pushgateway
Posted by GitBox <gi...@apache.org>.
UZi5136225 commented on pull request #1931:
URL: https://github.com/apache/hudi/pull/1931#issuecomment-671298995
0.8.0 correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org