[GitHub] [spark] constzhou commented on a change in pull request #35334: [SPARK-38034][SQL] Optimize TransposeWindow rule

[GitBox <gi...@apache.org>]

constzhou commented on a change in pull request #35334:
URL: https://github.com/apache/spark/pull/35334#discussion_r799218296



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TransposeWindowSuite.scala
##########
@@ -142,4 +142,20 @@ class TransposeWindowSuite extends PlanTest {
     comparePlans(optimized, analyzed)
   }
 
+  test("transpose two adjacent windows with compatible partitions which is not a prefix") {

Review comment:
       This will fail before. 
   This PR has two effects for the rule: 1. extend the applicable cases(like the case added in the UT) 2. perf improvement




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org