You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2018/08/16 12:09:49 UTC
tinkerpop git commit: TINKERPOP-1913 Corrected status attributes
messages after rebase
Repository: tinkerpop
Updated Branches:
refs/heads/TINKERPOP-1913 efddb703f -> 63d33d358
TINKERPOP-1913 Corrected status attributes messages after rebase
Test graphs are now named differently given the refactoring that went into improving integration configurations. Also fixed a bug in NO_CONTENT messages and added a test.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/63d33d35
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/63d33d35
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/63d33d35
Branch: refs/heads/TINKERPOP-1913
Commit: 63d33d3585cb6065f26eca9940b5dde085a47034
Parents: efddb70
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Thu Aug 16 08:08:11 2018 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Thu Aug 16 08:08:11 2018 -0400
----------------------------------------------------------------------
.../tinkerpop/gremlin/server/op/AbstractOpProcessor.java | 1 +
.../gremlin/server/GremlinResultSetIntegrateTest.java | 11 +++++++++--
2 files changed, 10 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/63d33d35/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
----------------------------------------------------------------------
diff --git a/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java b/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
index 46f7fc1..6e99b3f 100644
--- a/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
+++ b/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java
@@ -87,6 +87,7 @@ public abstract class AbstractOpProcessor implements OpProcessor {
if (managedTransactionsForRequest) attemptCommit(msg, context.getGraphManager(), settings.strictTransactionManagement);
ctx.writeAndFlush(ResponseMessage.build(msg)
.code(ResponseStatusCode.NO_CONTENT)
+ .statusAttributes(generateStatusAttributes(ctx, msg, ResponseStatusCode.NO_CONTENT, itty, settings))
.create());
return;
}
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/63d33d35/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
----------------------------------------------------------------------
diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
index bd71f1b..de17eb6 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinResultSetIntegrateTest.java
@@ -90,8 +90,15 @@ public class GremlinResultSetIntegrateTest extends AbstractGremlinServerIntegrat
}
@Test
- public void shouldReturnResponseAttributes() throws Exception {
- final ResultSet results = client.submit("g.V()");
+ public void shouldReturnResponseAttributesViaNoContent() throws Exception {
+ final ResultSet results = client.submit("[]");
+ final Map<String,Object> attr = results.statusAttributes().get(20000, TimeUnit.MILLISECONDS);
+ assertThat(attr.containsKey(Tokens.ARGS_HOST), is(true));
+ }
+
+ @Test
+ public void shouldReturnResponseAttributesViaSuccess() throws Exception {
+ final ResultSet results = client.submit("gmodern.V()");
final Map<String,Object> attr = results.statusAttributes().get(20000, TimeUnit.MILLISECONDS);
assertThat(attr.containsKey(Tokens.ARGS_HOST), is(true));
}