You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 15:13:43 UTC

[GitHub] [arrow] Dandandan commented on a change in pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString and DATE coercion

Dandandan commented on a change in pull request #8892:
URL: https://github.com/apache/arrow/pull/8892#discussion_r541944358



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -363,9 +363,9 @@ fn create_logical_plan(ctx: &mut ExecutionContext, query: usize) -> Result<Logic
             from
                 lineitem
             where
-                l_shipdate >= '1994-01-01'
-                and l_shipdate < '1995-01-01'
-                and l_discount between 0.06 - 0.01 and 0.06 + 0.01
+                l_shipdate >= date '1994-01-01'
+                and l_shipdate < date '1995-01-01'
+                and l_discount > 0.06 - 0.01 and l_discount < 0.06 + 0.01

Review comment:
       Shouldn't this have between that was also added recently? @seddonm1 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org