[GitHub] [skywalking] dmsolr commented on a change in pull request #4847: [WIP]Provide kafka as collector/reporter

[GitBox <gi...@apache.org>]

dmsolr commented on a change in pull request #4847:
URL: https://github.com/apache/skywalking/pull/4847#discussion_r448542089



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -140,6 +140,25 @@
          * Get profile task list interval
          */
         public static int GET_PROFILE_TASK_INTERVAL = 20;
+
+        public static class Kafka {
+
+            public static String BOOTSTRAP_SERVERS;
+
+            public static int BATCH_SIZE = 1000;
+
+            public static String ACKS = "1";
+
+            public static String TOPIC_METRICS = "skywalking-metrics";
+
+            public static String TOPIC_PROFILING = "skywalking-profiling";
+
+            public static String TOPIC_SEGMENT = "skywalking-segment";
+
+            public static String TOPIC_MANAGEMENT = "skywalking-management";

Review comment:
       If the topic not exists, Kafka will create it by itself.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org