You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "linzihao1999 (via GitHub)" <gi...@apache.org> on 2023/10/30 14:05:47 UTC
[PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
linzihao1999 opened a new pull request, #14668:
URL: https://github.com/apache/kafka/pull/14668
The tests in DescribeConsumerGroupTest in core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala update to support KRaft.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on code in PR #14668:
URL: https://github.com/apache/kafka/pull/14668#discussion_r1444787636
##########
core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala:
##########
@@ -351,7 +367,9 @@ class DescribeConsumerGroupTest extends ConsumerGroupCommandTest {
val (result, succeeded) = TestUtils.computeUntilTrue(service.collectGroupOffsets(group)) {
case (state, assignments) =>
val testGroupAssignments = assignments.toSeq.flatMap(_.filter(_.group == group))
+
Review Comment:
Let's try to not undo unnecessary changes like these
##########
core/src/test/scala/unit/kafka/admin/DescribeConsumerGroupTest.scala:
##########
@@ -35,9 +35,11 @@ class DescribeConsumerGroupTest extends ConsumerGroupCommandTest {
private val describeTypeState = Array(Array("--state"))
private val describeTypes = describeTypeOffsets ++ describeTypeMembers ++ describeTypeState
- @Test
- def testDescribeNonExistingGroup(): Unit = {
- TestUtils.createOffsetsTopic(zkClient, servers)
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testDescribeNonExistingGroup(quorum: String): Unit = {
+ createOffsetsTopic();
Review Comment:
Nit: Can we remove the unneeded semicolon?
Same below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
Posted by "linzihao1999 (via GitHub)" <gi...@apache.org>.
linzihao1999 commented on PR #14668:
URL: https://github.com/apache/kafka/pull/14668#issuecomment-1807388570
@dengziming Hi, I re-trigger the CI build and passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
Posted by "linzihao1999 (via GitHub)" <gi...@apache.org>.
linzihao1999 commented on PR #14668:
URL: https://github.com/apache/kafka/pull/14668#issuecomment-1788546638
@dengziming PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #14668:
URL: https://github.com/apache/kafka/pull/14668#issuecomment-1806737490
There seems some flaky related to this PR here: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14668/2/#showFailuresLink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-15741: KRaft support in DescribeConsumerGroupTest [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #14668:
URL: https://github.com/apache/kafka/pull/14668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org