You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/03/01 23:00:02 UTC

[kudu-CR] mini kdc: log when MiniKDC operations are slow

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6214

to review the following change.

Change subject: mini_kdc: log when MiniKDC operations are slow
......................................................................

mini_kdc: log when MiniKDC operations are slow

ExternalMiniClusterTest seems to occasionally fail due to a very slow
startup sequence of the MiniKDC. This patch adds some scoped logging to
try to pinpoint it.

Change-Id: Ibf332b1a2759b74e60fb1fa0408b609d4c833411
---
M src/kudu/security/test/mini_kdc.cc
M src/kudu/util/stopwatch.h
2 files changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/6214/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf332b1a2759b74e60fb1fa0408b609d4c833411
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] mini kdc: log when MiniKDC operations are slow

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: mini_kdc: log when MiniKDC operations are slow
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf332b1a2759b74e60fb1fa0408b609d4c833411
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] mini kdc: log when MiniKDC operations are slow

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: mini_kdc: log when MiniKDC operations are slow
......................................................................


mini_kdc: log when MiniKDC operations are slow

ExternalMiniClusterTest seems to occasionally fail due to a very slow
startup sequence of the MiniKDC. This patch adds some scoped logging to
try to pinpoint it.

Change-Id: Ibf332b1a2759b74e60fb1fa0408b609d4c833411
Reviewed-on: http://gerrit.cloudera.org:8080/6214
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/security/test/mini_kdc.cc
M src/kudu/util/stopwatch.h
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf332b1a2759b74e60fb1fa0408b609d4c833411
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>