You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/28 13:39:03 UTC
[GitHub] [incubator-nuttx] shuai532209720 opened a new pull request #4623: feat: driver: support double buffer for display
shuai532209720 opened a new pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623
## Summary
This PR is to support multiple buffers, like doube buffer. Reference linux kernel fbmem implement.
reference links:
https://github.com/torvalds/linux/blob/master/drivers/video/fbdev/core/fbmem.c
https://github.com/torvalds/linux/blob/master/drivers/video/fbdev/goldfishfb.c
## Impact
This PR will not affect the manufacturer's adaptation which has implement.
It just provides one more interface for multiple buffer.
## Testing
It has been verified on the chip of our project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r718474758
##########
File path: include/nuttx/video/fb.h
##########
@@ -315,11 +319,15 @@ struct fb_videoinfo_s
struct fb_planeinfo_s
{
- FAR void *fbmem; /* Start of frame buffer memory */
- size_t fblen; /* Length of frame buffer memory in bytes */
- fb_coord_t stride; /* Length of a line in bytes */
- uint8_t display; /* Display number */
- uint8_t bpp; /* Bits per pixel */
+ FAR void *fbmem; /* Start of frame buffer memory */
+ size_t fblen; /* Length of frame buffer memory in bytes */
+ fb_coord_t stride; /* Length of a line in bytes */
+ uint8_t display; /* Display number */
+ uint8_t bpp; /* Bits per pixel */
+ uint32_t xres_virtual; /* Virtual Horizontal resolution in pixel columns */
+ uint32_t yres_virtual; /* Virtual Vertical resolution in pixel rows */
+ uint32_t xoffest; /* X offset */
Review comment:
```suggestion
uint32_t xoffset; /* X offset */
```
Typo in the struct member
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] shuai532209720 commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
shuai532209720 commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r719054910
##########
File path: include/nuttx/video/fb.h
##########
@@ -283,6 +283,10 @@
#define FBIOGET_FRAMERATE _FBIOC(0x0015) /* Get frame rate
* Argument: int* */
+#define FBIOPAN_DISPLAY _FBIOC(0x0020) /* Pan display
Review comment:
New interfaces for specific controls may be added in the future. And FBIOPAN_DISPLAY don't belong spcific controls, so there's some space left over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] shuai532209720 closed pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
shuai532209720 closed pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r718468359
##########
File path: include/nuttx/video/fb.h
##########
@@ -283,6 +283,10 @@
#define FBIOGET_FRAMERATE _FBIOC(0x0015) /* Get frame rate
* Argument: int* */
+#define FBIOPAN_DISPLAY _FBIOC(0x0020) /* Pan display
Review comment:
```suggestion
#define FBIOPAN_DISPLAY _FBIOC(0x0016) /* Pan display
```
Why not follow the sequence?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] shuai532209720 commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
shuai532209720 commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r719054910
##########
File path: include/nuttx/video/fb.h
##########
@@ -283,6 +283,10 @@
#define FBIOGET_FRAMERATE _FBIOC(0x0015) /* Get frame rate
* Argument: int* */
+#define FBIOPAN_DISPLAY _FBIOC(0x0020) /* Pan display
Review comment:
New interfaces for LCDS may be added in the future. So there's some space left over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] shuai532209720 commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
shuai532209720 commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r719054910
##########
File path: include/nuttx/video/fb.h
##########
@@ -283,6 +283,10 @@
#define FBIOGET_FRAMERATE _FBIOC(0x0015) /* Get frame rate
* Argument: int* */
+#define FBIOPAN_DISPLAY _FBIOC(0x0020) /* Pan display
Review comment:
New interfaces for specific controls may be added in the future. And FBIOPAN_DISPLAY don't belong spcific controls, so there's some space left over. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r718468359
##########
File path: include/nuttx/video/fb.h
##########
@@ -283,6 +283,10 @@
#define FBIOGET_FRAMERATE _FBIOC(0x0015) /* Get frame rate
* Argument: int* */
+#define FBIOPAN_DISPLAY _FBIOC(0x0020) /* Pan display
Review comment:
```suggestion
#define FBIOPAN_DISPLAY _FBIOC(0x0016) /* Pan display
```
Why not follow the sequence?
##########
File path: include/nuttx/video/fb.h
##########
@@ -315,11 +319,15 @@ struct fb_videoinfo_s
struct fb_planeinfo_s
{
- FAR void *fbmem; /* Start of frame buffer memory */
- size_t fblen; /* Length of frame buffer memory in bytes */
- fb_coord_t stride; /* Length of a line in bytes */
- uint8_t display; /* Display number */
- uint8_t bpp; /* Bits per pixel */
+ FAR void *fbmem; /* Start of frame buffer memory */
+ size_t fblen; /* Length of frame buffer memory in bytes */
+ fb_coord_t stride; /* Length of a line in bytes */
+ uint8_t display; /* Display number */
+ uint8_t bpp; /* Bits per pixel */
+ uint32_t xres_virtual; /* Virtual Horizontal resolution in pixel columns */
+ uint32_t yres_virtual; /* Virtual Vertical resolution in pixel rows */
+ uint32_t xoffest; /* X offset */
Review comment:
```suggestion
uint32_t xoffset; /* X offset */
```
Typo in the struct member
##########
File path: include/nuttx/video/fb.h
##########
@@ -315,11 +319,15 @@ struct fb_videoinfo_s
struct fb_planeinfo_s
{
- FAR void *fbmem; /* Start of frame buffer memory */
- size_t fblen; /* Length of frame buffer memory in bytes */
- fb_coord_t stride; /* Length of a line in bytes */
- uint8_t display; /* Display number */
- uint8_t bpp; /* Bits per pixel */
+ FAR void *fbmem; /* Start of frame buffer memory */
+ size_t fblen; /* Length of frame buffer memory in bytes */
+ fb_coord_t stride; /* Length of a line in bytes */
+ uint8_t display; /* Display number */
+ uint8_t bpp; /* Bits per pixel */
+ uint32_t xres_virtual; /* Virtual Horizontal resolution in pixel columns */
+ uint32_t yres_virtual; /* Virtual Vertical resolution in pixel rows */
+ uint32_t xoffest; /* X offset */
+ uint32_t yoffset; /* Y offset */
Review comment:
Please, improve the documentation for these members to make them more intuitive. As a reference, see the documentation for the Linux struct:
https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/fb.h#L243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4623: feat: driver: support double buffer for display
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4623:
URL: https://github.com/apache/incubator-nuttx/pull/4623#discussion_r718478364
##########
File path: include/nuttx/video/fb.h
##########
@@ -315,11 +319,15 @@ struct fb_videoinfo_s
struct fb_planeinfo_s
{
- FAR void *fbmem; /* Start of frame buffer memory */
- size_t fblen; /* Length of frame buffer memory in bytes */
- fb_coord_t stride; /* Length of a line in bytes */
- uint8_t display; /* Display number */
- uint8_t bpp; /* Bits per pixel */
+ FAR void *fbmem; /* Start of frame buffer memory */
+ size_t fblen; /* Length of frame buffer memory in bytes */
+ fb_coord_t stride; /* Length of a line in bytes */
+ uint8_t display; /* Display number */
+ uint8_t bpp; /* Bits per pixel */
+ uint32_t xres_virtual; /* Virtual Horizontal resolution in pixel columns */
+ uint32_t yres_virtual; /* Virtual Vertical resolution in pixel rows */
+ uint32_t xoffest; /* X offset */
+ uint32_t yoffset; /* Y offset */
Review comment:
Please, improve the documentation for these members to make them more intuitive. As a reference, see the documentation for the Linux struct:
https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/fb.h#L243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org