You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Andreas Schaefer (JIRA)" <ji...@apache.org> on 2019/07/24 17:59:00 UTC

[jira] [Reopened] (SLING-8587) Sling Feature Maven Plugin does not work w/o proper FM setup

     [ https://issues.apache.org/jira/browse/SLING-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Schaefer reopened SLING-8587:
-------------------------------------

That fixed the issue of the Maven Clean but will not be sufficient to work with the Converters.

I would suggest that we either:
- postpone the parsing of the FM files until it is needed by Mojos
- allow to re-run the parsing of the FM files to account for generated FMs

Either way we should have two flags:
- one that marks when a (re-)parsing should be done due to FM generation
- one that marks when FM is settled (aggregate, attach ..) and generation should not be allowed anymore

Rerunning the parsing seems to do just fine as I just did really crude in my branch where the parsing is done on each FM handling Mojo.

> Sling Feature Maven Plugin does not work w/o proper FM setup
> ------------------------------------------------------------
>
>                 Key: SLING-8587
>                 URL: https://issues.apache.org/jira/browse/SLING-8587
>             Project: Sling
>          Issue Type: New Feature
>          Components: Feature Model
>    Affects Versions: slingfeature-maven-plugin 1.0.4
>            Reporter: Andreas Schaefer
>            Assignee: Carsten Ziegeler
>            Priority: Major
>             Fix For: slingfeature-maven-plugin 1.0.6
>
>
> Because this Maven Plugin does a check after the project is loaded it will fail if there is no feature files or other issues with the feature files even if that is resolved along the project's build.
> For example if for whatever reason the feature directory is not there or empty a 'mvn clean' will fail.
> Adding the convert content package Mojo to this feature is not working because there is no feature file at the beginning as they are created by the Mojo.
> This tests should be moved to the Mojo that depend on it and it must be executed on each Mojo as the features can have been changed in the meantime.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)