You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:24:09 UTC

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #64: chore: introduce a log package

tokers commented on a change in pull request #64:
URL: https://github.com/apache/apisix-ingress-controller/pull/64#discussion_r538258282



##########
File path: go.mod
##########
@@ -3,25 +3,18 @@ module github.com/api7/ingress-controller
 go 1.13
 
 require (
-	github.com/coreos/etcd v3.3.18+incompatible
-	github.com/coreos/go-semver v0.3.0 // indirect
-	github.com/coreos/go-systemd v0.0.0-20180511133405-39ca1b05acc7 // indirect
-	github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f // indirect
 	github.com/gogo/protobuf v1.3.1 // indirect
 	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
-	github.com/google/uuid v1.1.1 // indirect
+	github.com/golang/protobuf v1.3.2 // indirect
 	github.com/gxthrj/apisix-ingress-types v0.1.2
 	github.com/gxthrj/apisix-types v0.1.0
 	github.com/gxthrj/seven v0.1.9
 	github.com/julienschmidt/httprouter v1.3.0
-	github.com/pkg/errors v0.8.1
+	github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect

Review comment:
       It's not used directly.
   
   ![image](https://user-images.githubusercontent.com/10428333/101477921-dd89d580-398a-11eb-812c-03d2bd0654a0.png)
   
   I think we shouldn't modify it to avoid any compatibility broken.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org