You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/10 18:09:04 UTC
[jira] [Commented] (BOOKKEEPER-1057) Do not log error message after
read failure in PendingReadOp
[ https://issues.apache.org/jira/browse/BOOKKEEPER-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005129#comment-16005129 ]
ASF GitHub Bot commented on BOOKKEEPER-1057:
--------------------------------------------
GitHub user merlimat opened a pull request:
https://github.com/apache/bookkeeper/pull/145
BOOKKEEPER-1057: Do not log error message after read failure in PendingReadOp
In PendingReadOp, there is an error message that is printed each time a read on a specific bookie is failing:
```java
LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First unread entry is {}",
new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts, firstUnread });
```
This message is getting printed each time a ledger is recovered and there is no error, since the ledger recovery logic is to keep reading and incrementing the entryId until a NoEntry error is received.
This log message should be set at debug level.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merlimat/bookkeeper debug-message
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/145.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #145
----
commit 30d94f2325882d5d41c4d3eb92b3e05c5393538b
Author: Matteo Merli <mm...@apache.org>
Date: 2016-01-12T18:05:01Z
BOOKKEEPER-1057: Do not log error message after read failure in PendingReadOp
----
> Do not log error message after read failure in PendingReadOp
> ------------------------------------------------------------
>
> Key: BOOKKEEPER-1057
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1057
> Project: Bookkeeper
> Issue Type: Task
> Reporter: Matteo Merli
> Assignee: Matteo Merli
> Priority: Trivial
> Fix For: 4.5.0
>
>
> In {{PendingReadOp}}, there is an error message that is printed each time a read on a specific bookie is failing:
> {noformat}
> LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First unread entry is {}",
> new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts, firstUnread });
> {noformat}
> This message is getting printed each time a ledger is recovered and there is no error, since the ledger recovery logic is to keep reading and incrementing the entryId until a NoEntry error is received.
> This log message should be set at debug level.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)