[jira] Commented: (SYNAPSE-443) If ClientHandler receives a response of bad request from http server, causes many NullPointerExceptions.

["Ruwan Linton (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYNAPSE-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636522#action_12636522 ] 

Ruwan Linton commented on SYNAPSE-443:
--------------------------------------

Can you please point me how to reproduce this issue? By looking at the code your suggestion seems to work because even in the case of unknown status code we call processResponse(), but I need to test this before committing the fix.

> If ClientHandler receives a response of bad request from http server, causes many NullPointerExceptions.
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SYNAPSE-443
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-443
>             Project: Synapse
>          Issue Type: Bug
>          Components: Transports
>    Affects Versions: 1.3
>            Reporter: Jason Walton
>            Assignee: Ruwan Linton
>
> In ClientHandler.responseReceived(), if the resposne.getStatusLine().getStatusCode() is HttpStatus.SC_BAD_REQUEST, we log the error and return.  After this, IO Reactor tries to stream the response content to us with a call to inputReady(), however the RESPONSE_SINK_BUFFER will be null, so we throw a NullPointerException.  IO Reactor will continue to try to deliver content to us, so the result is a huge pile of NullPointerExceptions.
> Easy fix seems to be to call "processResponse()" in the SC_BAD_REQUEST case of the switch statement, like every other case does.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org