You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/15 12:53:09 UTC

[GitHub] [airflow] henryzhangsta opened a new pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

henryzhangsta opened a new pull request #17027:
URL: https://github.com/apache/airflow/pull/17027


   This fixes a regression in 2.1 where subclasses of BaseOperator could no
   longer use `__init_subclass__` to allow class instantiation time
   customization.
   
   Related BPO: https://bugs.python.org/issue29581
   
   closes: https://github.com/apache/airflow/issues/17014


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] henryzhangsta commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

henryzhangsta commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-881322777


   @uranusjr Are these test failures flakes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-882246641


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] henryzhangsta commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

henryzhangsta commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-882275648


   Rebased but last time failed with `/opt/airflow/scripts/in_container/run_ci_tests.sh: line 26:   348 Segmentation fault      (core dumped) pytest "${@}"` on a test that succeeded previous run. I wonder if you can just rerun specific steps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-881019050


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-881490719


   Just rebase and push. I believe the helm chart ones are not .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-885274555


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-882307416


   You can't, but I think the failure is just flaky. Don't worry about it, it's not required to pass for merging anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil merged pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

kaxil merged pull request #17027:
URL: https://github.com/apache/airflow/pull/17027


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17027: Core: Enable the use of __init_subclass__ in subclasses of BaseOperator

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #17027:
URL: https://github.com/apache/airflow/pull/17027#issuecomment-880669137

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org